Merged
Conversation
Contributor
geimer
commented
Apr 21, 2016
- Actually pass compiler flag to configure
- Allow building with dummy toolchain
Allow building with dummy toolchain
|
Automatic reply from Jenkins: Can I test this? |
| compiler_opt = known_compilers[comp_fam] | ||
| else: | ||
| raise EasyBuildError("Compiler family not supported yet: %s" % comp_fam) | ||
| self.cfg.update('configopts', compiler_opt) |
Member
There was a problem hiding this comment.
so, compiler_opt was not used at all before...?
Contributor
Author
There was a problem hiding this comment.
Apparently, no. So, one could argue that this flag doesn't matter as the easyblock has worked fine until now, but I can't say for sure which consequences omitting this flag really has. I guess that configure always picked up GCC, regardless of the actual toolchain...
Member
|
Jenkins: ok to test |
|
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1901/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.