ENH: Support for WRF >= 3.7#902
Conversation
|
Automatic reply from Jenkins: Can I test this? |
|
Jenkins: ok to test |
|
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1933/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
| if self.comp_fam == toolchain.INTELCOMP: #@UndefinedVariable | ||
| build_type_option = "Linux x86_64 i486 i586 i686, ifort compiler with icc" | ||
| build_type_option = ("INTEL\ \(ifort\/icc\)" if LooseVersion(self.version) >= LooseVersion('3.7') | ||
| else "Linux x86_64 i486 i586 i686, ifort compiler with icc") |
There was a problem hiding this comment.
@andreas-h I would reformat this to this, for readability:
if LooseVersion(self.version) >= LooseVersion('3.7'):
build_type_option = "INTEL\ \(ifort\/icc\)"
else:
build_type_option = "Linux x86_64 i486 i586 i686, ifort compiler with icc"same below
|
@andreas-h this looks very good, thanks a lot for looking into this! Do you have an updated easyconfig file as well, that can be used as a testcase for this change? |
|
@boegel I have an easyconfig file which I suppose is correct, but it currently does not build successfully on my system. But I guess this isn't easybuild related, as I also have trouble building directly (i.e., without EasyBuild). I uploaded the easyconfig file I'm using here: https://gist.github.com/andreas-h/de2af52d1348a00b308997717986655d but not all dependencies are in the easybuild-easyconfigs repo yet, I guess. I uploaded the build output showing my problems here: https://gist.github.com/andreas-h/c9ec2df5dea7a0ac18bed2e3643ad2e7 but I guess that's is off-topic for this issue ;) |
|
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1936/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
@andreas-h that log doesn't correspond to the The problem in the log is that |
|
@andreas-h ah, sorry, you have both easyconfigs in your gist... are you hitting similar problems when using |
|
@andreas-h one extra change is required for recent versions of WRF, cfr. andreas-h#1 |
nup.exe was 'temporarily removed' in WRF 3.7
|
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1937/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
@andreas-h I opened a PR with an easyconfig for WRF 3.8, see easybuilders/easybuild-easyconfigs#2963 Works for me using your updated easyblock, thanks! |
|
tested with both existing WRF easyconfigs, and the one in easybuilders/easybuild-easyconfigs#2963, so good to go Thanks @andreas-h! |
WRF changed its
configurescript in version 3.7. This PR checks for WRF version and handles both cases (version <= 3.6 and version >= 3.7)