Conversation
|
|
||
| def make_module_extra(self): | ||
| """Set up a BOOST_ROOT environment variable to e.g. ease Boost handling by cmake""" | ||
| txt = super(EB_Boost, self).make_module-extra() |
There was a problem hiding this comment.
@jhein32 you have a syntax error here, should be make_module_extra(), not make_module-extra()
when you make changes to an existing easyblock, please make sure you test it too, by (re)building a Boost module in this case
you can make sure that your modified easyblock is being used via --include-easyblocks (see http://easybuild.readthedocs.io/en/latest/Including_additional_Python_modules.html#include-easyblocks)
|
Noticed the travis failures. Edited the file via website. |
|
@boegel I was fighting with the git-hub desktop and it seems to have done a merge of master into a develop (not sure my private or the hpcugent). Could you review that this has no site-effect? |
|
@jhein32 you added an empty merge commit indeed, but don't worry about that too much, we're not purists there and it has no negative side-effects PR looks OK now, I'll give it a test on my end but I don't expect problems, should be good to go |
|
Ran a manual check, rebuilding one of our boost modules. The module file contains the BOOST_ROOT variable and the value appears correct :) |
…ost_root_env-variable
|
lgtm, thanks @jhein32! |
have boost modules set up a BOOST_ROOT environment variable for use by e.g. cmake