Small sanity check change to openfoam block#986
Merged
boegel merged 3 commits intoeasybuilders:developfrom Sep 5, 2016
Merged
Conversation
vorticity is superseded by postprocess in OpenFOAM 4.0. I have replaced it by the wdot binary which seems to be present in all OpenFOAM(-Extend) releases to date.
Member
Author
|
@hajgato FYI |
| if len(contents_installdir) == 1 and os.path.isdir(os.path.join(self.installdir, contents_installdir[0])): | ||
| if len(contents_installdir) == 1 and \ | ||
| os.path.isdir(os.path.join(self.installdir, contents_installdir[0])): | ||
| source = os.path.join(self.installdir, contents_installdir[0]) |
Member
There was a problem hiding this comment.
@wpoely86 better move source outside of the if, I don't like this use of \
Member
Author
There was a problem hiding this comment.
if that rocks your boat but there's nothing wrong with backslashes
Member
There was a problem hiding this comment.
we rarely use them elsewhere in the EB codebase, just a matter of consistency
Member
|
looks ok & tested with a couple of existing OpenFOAM easyconfigs, so good to go, thanks @wpoely86! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In openfoam 4.0, the
vorticitybinary is superseded by postproces. I've replaced it bywdotwhich seems to be present in all releases so far.