Skip to content

disable unintended octave support in all libsndfile easyconfigs#10027

Merged
lexming merged 1 commit intoeasybuilders:developfrom
migueldiascosta:20200310112149_new_pr_libsndfile1028
Mar 17, 2020
Merged

disable unintended octave support in all libsndfile easyconfigs#10027
lexming merged 1 commit intoeasybuilders:developfrom
migueldiascosta:20200310112149_new_pr_libsndfile1028

Conversation

@migueldiascosta
Copy link
Copy Markdown
Member

@migueldiascosta migueldiascosta commented Mar 10, 2020

(created using eb --new-pr)

without this, installation fails if octave is available in the OS, as reported in #9781

@migueldiascosta
Copy link
Copy Markdown
Member Author

Test report by @migueldiascosta
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in this PR)
sms - Linux centos linux 7.6.1810, AMD EPYC 7601 32-Core Processor, Python 2.7.5
See https://gist.github.com/2b4587d116ec7f0980d3f6e178e6f87c for a full test report.

@migueldiascosta
Copy link
Copy Markdown
Member Author

test report is with octave installed from an OS package.

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Mar 17, 2020

Test report by @lexming
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in this PR)
login2.cerberus.os - Linux centos linux 7.7.1908, Intel(R) Xeon(R) Gold 6126 CPU @ 2.60GHz, Python 2.7.5
See https://gist.github.com/6de97951624ae7f0cd2cde3c939f7bec for a full test report.

Copy link
Copy Markdown
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Mar 17, 2020

Going in, thanks @migueldiascosta !

@lexming lexming merged commit 3a803a7 into easybuilders:develop Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants