Skip to content

{lib}[foss/2018b] LIBSVM v3.23#10045

Merged
smoors merged 5 commits intoeasybuilders:developfrom
tstrempel:20200311210738_new_pr_LIBSVM323
Mar 14, 2020
Merged

{lib}[foss/2018b] LIBSVM v3.23#10045
smoors merged 5 commits intoeasybuilders:developfrom
tstrempel:20200311210738_new_pr_LIBSVM323

Conversation

@tstrempel
Copy link
Copy Markdown
Contributor

(created using eb --new-pr)

@tstrempel
Copy link
Copy Markdown
Contributor Author

patch needed to create libsvm.so

Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tstrempel are these changes needed for the intel version of LIBSVM too? if so, please update that easyconfig as well.

Comment thread easybuild/easyconfigs/l/LIBSVM/LIBSVM-3.23_shared_lib.patch
@tstrempel
Copy link
Copy Markdown
Contributor Author

@tstrempel are these changes needed for the intel version of LIBSVM too? if so, please update that easyconfig as well.

I don't use the intel toolchain, so I can't say this for certain.
I'll update the intel easyconfigs after this pull request is accepted.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Mar 13, 2020

I prefer to have them both in the same PR. If you add the updated intel version, I or someone else can test it for you.

@tstrempel
Copy link
Copy Markdown
Contributor Author

@smoors I updated the LIBSVM-3.23-intel-2018b.eb EasyConfig with the patch

@zao
Copy link
Copy Markdown
Contributor

zao commented Mar 13, 2020

Test report by @zao
FAILED
Build succeeded for 1 out of 2 (2 easyconfigs in this PR)
freja - Linux ubuntu 18.04, Intel(R) Core(TM) i7-8700K CPU @ 3.70GHz, Python 2.7.17
See https://gist.github.com/3ab2c93a3b54faf1347832fcaa034601 for a full test report.

@zao
Copy link
Copy Markdown
Contributor

zao commented Mar 13, 2020

Ignore the intel/2018b part of my test report, the machine cannot run such an old Intel compiler. 🤡
The foss part built fine.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Mar 13, 2020

Test report by @smoors
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node377.hydra.os - Linux centos linux 7.7.1908, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/614953faf852e1916d1276dbbc0911de for a full test report.

Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors smoors added this to the next release (4.2.0) milestone Mar 14, 2020
@smoors
Copy link
Copy Markdown
Contributor

smoors commented Mar 14, 2020

Going in, thanks @tstrempel!

@smoors smoors merged commit 0b879b8 into easybuilders:develop Mar 14, 2020
@easybuilders easybuilders deleted a comment from boegelbot Mar 28, 2020
@easybuilders easybuilders deleted a comment from boegelbot Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants