Skip to content

Don't run the Bloom tests for Jellyfish, they can randomly fail#1016

Merged
boegel merged 1 commit intoeasybuilders:developfrom
JensTimmerman:Jellyfish
Jun 3, 2015
Merged

Don't run the Bloom tests for Jellyfish, they can randomly fail#1016
boegel merged 1 commit intoeasybuilders:developfrom
JensTimmerman:Jellyfish

Conversation

@JensTimmerman
Copy link
Copy Markdown

No description provided.

@fgeorgatos
Copy link
Copy Markdown
Contributor

btw. just a hint: each single time you see some random failures, make the extra check if the random failure occurs also a non-parallel-fs (eg. try /tmp as both build and installdir). Also, be aware that certain software may have issues when it is built within /dev/shm and the like, for the opposite reason: the fast fs may expose race conditions in the build/install logic.

@fgeorgatos
Copy link
Copy Markdown
Contributor

ps. if the random failure is exclusively due to statistics, you can improve them a bit via voting (ie. run the test 3 times, keep 2 for success), but I'd agree that it would never be 100% reliable and that gives a good excuse for the current PR...

@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 28, 2014

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
Linux SL 6.6, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/bd15503337a3f52c046f for a full test report.

@JensTimmerman
Copy link
Copy Markdown
Author

@fgeorgatos these are actually random tests, that randomly fail. The bloom filter is a data structure with some random properties, the tests test these random properties, but because of randomness they somtimes fail, it's a bad test, the author told me it was, and we can safely skip it. so, good to go?

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 3, 2015

Jenkins: test this please

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 3, 2015

@JensTimmerman: test report (re)submitted, ping me when it comes back (I won't be notified)

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3274/
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3274/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 3, 2015

@JensTimmerman: please sync this with develop, test report fails because easyconfig file doens't include an easyblock line yet (unit tests don't catch this, because they check post merge with develop)

This actually raises an important issue with the test reports... :-/

@JensTimmerman
Copy link
Copy Markdown
Author

@boegel rebased on develop

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 3, 2015

Hmm, I saw this same change in another PR (and now I can't find it anymore...)

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 3, 2015

Ah, found it again: #1035.

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3297/
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3297/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 3, 2015

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
Linux SL 6.6, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/fb64b5ea6578d2ca0cc2 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 3, 2015

Going in, thanks @JensTimmerman!

boegel added a commit that referenced this pull request Jun 3, 2015
Don't run the Bloom tests for Jellyfish, they can randomly fail
@boegel boegel merged commit 3573da0 into easybuilders:develop Jun 3, 2015
@JensTimmerman JensTimmerman deleted the Jellyfish branch June 3, 2015 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants