Skip to content

{bio}[intel/2019b] CGmapTools v0.1.2, SAMtools v0.1.20#10288

Merged
boegel merged 4 commits intoeasybuilders:developfrom
Darkless012:20200330211242_new_pr_CGmapTools012
Mar 31, 2020
Merged

{bio}[intel/2019b] CGmapTools v0.1.2, SAMtools v0.1.20#10288
boegel merged 4 commits intoeasybuilders:developfrom
Darkless012:20200330211242_new_pr_CGmapTools012

Conversation

@Darkless012
Copy link
Copy Markdown
Contributor

@Darkless012 Darkless012 commented Mar 30, 2020

(created using eb --new-pr)

@Darkless012
adding easyconfigs: CGmapTools-0.1.2-intel-2019b.eb, SAMtools-0.1.20-…
3ec0c6b 
…intel-2019b.eb and patches: CGmapTools-0.1.2_add-Makefile.patch
boegel
boegel requested changes Mar 30, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Darkless012

  • Please use buildopts to ensure the right compilers and compiler flags are used: 
    buildopts = 'CC="$CC" CXX="$CXX" CFLAGS="$CFLAGS" CXXFLAGS="$CXXFLAGS"'
  • You'll need to add an exception for CGmapTools in test/easyconfigs/easyconfigs.py

Comment thread easybuild/easyconfigs/c/CGmapTools/CGmapTools-0.1.2_add-Makefile.patch Outdated
@boegel boegel added this to the 4.x milestone Mar 30, 2020
@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 30, 2020

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
generoso - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2660 v4 @ 2.00GHz, Python 3.6.8
See https://gist.github.com/f59978d1befba8e0fc28ee6293071ffa for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 30, 2020

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
gligar04.gastly.os - Linux centos linux 7.7.1908, Intel(R) Xeon(R) Gold 6130 CPU @ 2.10GHz, Python 3.6.8
See https://gist.github.com/b3dc36cdcdd341d01cff31a2e2f19d6f for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 30, 2020

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node2616.swalot.os - Linux centos linux 7.7.1908, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/3b051a2b42884718393324ad34a5737d for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 31, 2020

Going in, thanks @Darkless012!

@boegel boegel merged commit be8305a into easybuilders:develop Mar 31, 2020
@boegel boegel modified the milestones: 4.x, next release (4.2.0) Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

new update

Projects

None yet

Milestone

4.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@Darkless012 @boegel