SSAHA2 easyconfigs for 64 and 32bits binaries by pescobar · Pull Request #1039 · easybuilders/easybuild-easyconfigs

pescobar · 2014-08-23T16:03:55Z

No description provided.

fgeorgatos · 2014-08-23T20:25:26Z

you could drop the "" since it is empty, and remove the extra line at the very end; ditto for the other file. all other OK

IIRC I think @boegel asked me to add the "" when sanity checks is empty

@boegel am I wrong?

i've got some comment like 1yr ago ;-) otherwise this looks good

@pescobar: I don't think I ever said this, and if I did, I was wrong, so wrong.

Please change to

dirs: [],

pescobar#37

boegel's PR is a good example why it worths prioritizing high to merge in older PRs ;-)
(or you end up with 3800 changed files to be merged in...)

yeah, the sync with develop can be painful, indeed...

the main reason for them is to make sure that the latest version of the unit tests are run by Jenkins (since Jenkins just checks out the branch that corresponds to the PR)

maybe we should see if we can make Jenkins merge with develop first, and then run the tests...

boegel · 2014-11-28T09:46:24Z

Test report by @boegel
FAILED
Build succeeded for 0 out of 2 (2 easyconfigs in this PR)
Linux SL 6.6, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/44f3eaaeb660e5ec5874 for a full test report.

boegel · 2014-11-28T10:01:29Z

Test report by @boegel
FAILED
Build succeeded for 0 out of 2 (2 easyconfigs in this PR)
Linux SL 6.6, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/801f3e55cd366c5f7dbc for a full test report.

fgeorgatos · 2015-02-11T18:30:31Z

Test report by @fgeorgatos
SUCCESS
Build succeeded for 2 out of 2
Linux debian 6.0.10, Intel(R) Xeon(R) CPU L5640 @ 2.27GHz, Python 2.6.6
See https://gist.github.com/445e6d731d63033d2b2f for a full test report.

fgeorgatos · 2015-09-23T15:55:07Z

drop last lines on ecs, this triggers -gasp- Jenkins testing.

lgtm , put this in REVIEW

pescobar · 2015-09-23T17:17:50Z

Test report by @pescobar
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
Linux centos 6.5, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/2a55d5dc3ebf0d607740 for a full test report.

rjeschmi · 2015-09-23T17:47:39Z

Test report by @rjeschmi
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
Linux centos 6.6, AMD Opteron(tm) Processor 6380, Python 2.6.6
See https://gist.github.com/56e95438d2476fc60db6 for a full test report.

hpcugentbot · 2015-09-23T18:24:50Z

Easyconfigs unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4473/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

boegel · 2015-09-23T18:32:30Z

dirs: [],

sync with develop & fix style remarks

boegel · 2015-09-25T07:07:17Z

Jenkins: test this please

hpcugentbot · 2015-09-25T08:19:30Z

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4518/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

boegel · 2015-09-25T10:11:49Z

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
Linux SL 6.7, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/c6374d9e930b351436a2 for a full test report.

boegel · 2015-09-25T10:13:01Z

Going in, thanks @pescobar!

SSAHA2 easyconfigs for 64 and 32bits binaries

SSAHA2 easyconfigs for 64 and 32bits binaries

72844a7

fgeorgatos reviewed Aug 23, 2014
View reviewed changes

fgeorgatos reviewed Sep 23, 2015
View reviewed changes

removed empty lines

4b9c2ca

boegel reviewed Sep 23, 2015
View reviewed changes

Comment thread easybuild/easyconfigs/s/SSAHA2/SSAHA2-2.5.5-x86_64.eb Outdated

Copy link
Copy Markdown

Member

boegel Sep 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dirs: [],

boegel added this to the merge sprint 2.0 milestone Sep 23, 2015

boegel added 2 commits September 23, 2015 20:33

Merge branch 'develop' into SSAHA2

69a97c2

fix style issues

b0cc975

boegel mentioned this pull request Sep 23, 2015

sync with develop & fix style remarks pescobar/easybuild-easyconfigs#37

Merged

boegel and others added 2 commits September 23, 2015 20:45

fix versionsuffix

97f9a22

Merge pull request #37 from boegel/SSAHA2

784c781

sync with develop & fix style remarks

boegel added a commit that referenced this pull request Sep 25, 2015

Merge pull request #1039 from pescobar/SSAHA2

2cb830a

SSAHA2 easyconfigs for 64 and 32bits binaries

boegel merged commit 2cb830a into easybuilders:develop Sep 25, 2015

Conversation

pescobar commented Aug 23, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

boegel commented Nov 28, 2014

Uh oh!

boegel commented Nov 28, 2014

Uh oh!

fgeorgatos commented Feb 11, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pescobar commented Sep 23, 2015

Uh oh!

rjeschmi commented Sep 23, 2015

Uh oh!

hpcugentbot commented Sep 23, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

boegel commented Sep 25, 2015

Uh oh!

hpcugentbot commented Sep 25, 2015

Uh oh!

boegel commented Sep 25, 2015

Uh oh!

boegel commented Sep 25, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants