Skip to content

{bio}[SYSTEM] GSEA v4.0.3#10395

Merged
boegel merged 11 commits intoeasybuilders:developfrom
rtripath89:gsea
Dec 29, 2020
Merged

{bio}[SYSTEM] GSEA v4.0.3#10395
boegel merged 11 commits intoeasybuilders:developfrom
rtripath89:gsea

Conversation

@rtripath89
Copy link
Copy Markdown
Contributor

No description provided.

@rtripath89
Copy link
Copy Markdown
Contributor Author

rtripath89 commented Apr 20, 2020

@boegel : Hi, can I get a little clarification on these errors, as it looks like it's code style errors, but I can't figure out, where I need to make modifications for it.

@easybuilders easybuilders deleted a comment from boegelbot Apr 24, 2020
Copy link
Copy Markdown
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The style checks fail because the line I highlighted here below is too long. On the other hand, will GSEA work in the SYSTEM toolchain with no dependencies at all? I'm not familiar with it.

Comment thread easybuild/easyconfigs/g/GSEA/GSEA-4.0.3.eb Outdated
@lexming lexming changed the title Gsea {bio}[SYSTEM] Gsea v4.0.3 Apr 24, 2020
@lexming lexming added the new label Apr 24, 2020
@lexming lexming added this to the 4.x milestone Apr 24, 2020
@rtripath89
Copy link
Copy Markdown
Contributor Author

The style checks fail because the line I highlighted here below is too long. On the other hand, will GSEA work in the SYSTEM toolchain with no dependencies at all? I'm not familiar with it.

It should ...... it does depend on Java, so I have added it as a dependency, in case a system doesn't contain Java.

@easybuilders easybuilders deleted a comment from boegelbot Dec 29, 2020
@easybuilders easybuilders deleted a comment from boegelbot Dec 29, 2020
@boegel boegel changed the title {bio}[SYSTEM] Gsea v4.0.3 {bio}[SYSTEM] GSEA v4.0.3 Dec 29, 2020
@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 29, 2020

@boegelbot please test @ generoso

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 29, 2020

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3501.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/e3f78059962863bd152628a5fd88c7f4 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=10395 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_10395 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12348

Test results coming soon (I hope)...

Details

- notification for comment with ID 752016852 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
generoso-c1-s-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/cf51ae3970c1320a7665970d0f9012ce for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 29, 2020

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node2710.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/ef836cd6885b89c5a6ac2fabf9a59dda for a full test report.

Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel dismissed lexming’s stale review December 29, 2020 10:13

long line fixed

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 29, 2020

Going in, thanks @rtripath89!

@boegel boegel removed this from the 4.x milestone Dec 29, 2020
@boegel boegel added this to the next release (4.3.3?) milestone Dec 29, 2020
@boegel boegel merged commit 0218d85 into easybuilders:develop Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants