Skip to content

{math}[foss/2019a] gretl v2020a#10413

Merged
lexming merged 5 commits intoeasybuilders:developfrom
tardigradus:20200416141810_new_pr_gretl2020a
Apr 30, 2020
Merged

{math}[foss/2019a] gretl v2020a#10413
lexming merged 5 commits intoeasybuilders:developfrom
tardigradus:20200416141810_new_pr_gretl2020a

Conversation

@tardigradus
Copy link
Copy Markdown
Contributor

@tardigradus tardigradus commented Apr 16, 2020

(created using eb --new-pr)

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Apr 24, 2020

Test report by @lexming
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in this PR)
node154.hydra.os - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) CPU E5-2680 v2 @ 2.80GHz, Python 2.7.5
See https://gist.github.com/fd0e544d072f80d6c09a056780238d5f for a full test report.

@easybuilders easybuilders deleted a comment from boegelbot Apr 24, 2020
lexming
lexming requested changes Apr 24, 2020
View reviewed changes
Comment thread easybuild/easyconfigs/g/gretl/gretl-2020a-foss-2019a.eb
Comment thread easybuild/easyconfigs/g/gretl/gretl-2020a-foss-2019a.eb Outdated
@lexming
Copy link
Copy Markdown
Contributor

lexming commented Apr 29, 2020

Test report by @lexming
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node051.manticore.os - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) CPU E5-2650L v2 @ 1.70GHz, Python 2.7.5
See https://gist.github.com/2cb9214a61e2682186ed530fff98d6e8 for a full test report.

lexming
lexming requested changes Apr 29, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing my review. Now the build of gretl works fine.
We would just need to correct the sanity_check_paths to accept your PR, it should also check for the lib files and include folder.

Comment thread easybuild/easyconfigs/g/gretl/gretl-2020a-foss-2019a.eb Outdated
@tardigradus @lexming
Update easybuild/easyconfigs/g/gretl/gretl-2020a-foss-2019a.eb
01347e8 
Add extra paths to sanity_check_paths

Co-Authored-By: Alex Domingo <[email protected]>
@lexming
Copy link
Copy Markdown
Contributor

lexming commented Apr 30, 2020

Test report by @lexming
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node051.manticore.os - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) CPU E5-2650L v2 @ 1.70GHz, Python 2.7.5
See https://gist.github.com/ea1a839f9790d85c612653b64fdf8c27 for a full test report.

lexming
lexming approved these changes Apr 30, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lexming lexming added the new label Apr 30, 2020
@lexming lexming added this to the next release (4.2.1?) milestone Apr 30, 2020
@lexming
Copy link
Copy Markdown
Contributor

lexming commented Apr 30, 2020

Going in, thanks @tardigradus !

@lexming lexming merged commit 44a242d into easybuilders:develop Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lexming lexming lexming approved these changes

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

4.2.1

Development

Successfully merging this pull request may close these issues.

2 participants

@tardigradus @lexming