{data,math}[foss/2018b] rootpy v1.0.1, root_numpy v4.8.0 w/ Python 3.6.6#10424
Conversation
|
This PR (specifically the new root_numpy module) depends on #10377, which has passed its checks but hasn't been reviewed or merged. Should I merge that PR's two entries onto this branch, or wait for that PR to be merged and retrigger the checks here? |
lexming
left a comment
There was a problem hiding this comment.
@kelseymh if this easyconfig needs numpy v1.18.2 it will not be possible to merge it into our repository. We have a rule to limit the number of dependencies in a toolchain to a single version of each package. Therefore in foss/2018b it is only possible to use numpy v1.15.0 provided by Python-3.6.6-foss-2018b.eb. The reason being that this repository would be very bloated and difficult to manage if all combinations of versions were allowed for every toolchain.
If this new version of ROOT really needs numpy v1.18.2, you will be able to submit it for merging into foss/2020a once it is available (it will have numpy v1.18). Instead, if it can be used with numpy v1.15.0, we can accept it into foss/2018b. It just needs to depend on Python-3.6.6-foss-2018b.eb.
|
Thank you, @lexming. I don't see why we can't use numpy v1.15.0; I'll have to do the build and make sure there are no hiccups. I chose the "latest and greatest" just because... The dependence is actually that root_numpy uses both ROOT and numpy, combining the two into a useful Python analysis tool. It will depend on both ROOT/6.14.06-foss-2018b-Python-3.6.6.eb and Python-3.6.6-foss-2018b.eb. If I can use numpy-1.15.0-blah-blah, then I will update this PR. |
|
I'm not sure why those extra files, especially the numpy-1.15.0 and Cython-0.29.16, got pulled in here. I used |
I don't know why this file was pulled in by `eb --update-pr`, but it's not the correct version.
|
@kelseymh you can remove any file from this PR by prepending a colon to the name of the easyconfig
update: and |
…gs into 20200415_new_ROOT-based_Python_packages
…m new root_numpy, provided by Python-3.6.6.
…ings and whitespace.
…eck-contrib doesn't report this.
|
Question: in the previous round of failed checks, it complained about "http://" in the Rootpy's Web site is only http://www.rootpy.org/. It doesn't have an https://www.rootpy.org/ server. Does the validation test check whether https:// works, before complaining about it? |
Yes Thanks for updating this PR, I'll start testing it. |
|
Test report by @lexming |
|
@lexming Naive question: Should checksums change on a distribution like this? Why didn't my own builds of this .eb file (on TAMU HPRC) fail if the checksum was wrong? |
|
@kelseymh you should check why that happened, is your first tarball corrupted? does its contents differ from the tarball that can be downloaded today? |
|
To be quite honest. I don't know where the previous checksum arose. The "7d85fc8f" checksum was in the file I initially committed in my local EC repository. I tried grepping for it in my other .eb files (i.e., a misplaced copy-paste), but no matches. In the original version of rootpy-1.0.1, which I used to actually build the module for my group, the .eb file didn't have a The rootpy file which was downloaded as part of that (successful) installation, without a checksum. I ran |
|
Test report by @lexming |
lexming
left a comment
There was a problem hiding this comment.
The build works well. We need one last change for rootpy adding all executables in bin to sanity_check_paths. I also suggest a couple changes to use a formatting more in line with the other easyconfigs.
…-Python-3.6.6.eb Co-Authored-By: Alex Domingo <[email protected]>
…3.6.6.eb Co-Authored-By: Alex Domingo <[email protected]>
…3.6.6.eb Co-Authored-By: Alex Domingo <[email protected]>
|
Thank you, @lexming . I'm glad those were all stylistic issues, and not functional. I'll learn all this stuff eventually :-) |
|
Test report by @lexming |
|
Going in, thanks for following up on this PR @kelseymh ! |
rootpy-1.0.1-foss-2018b-Python-3.6.6.eb is an update for Python 3.6.6 support, which ROOT hasn't had up to now.
root_numpy-4.8.0-foss-2018b-Python-3.6.6.eb is an entirely new package for EasyBuild, which provides integrated ROOT and Numpy array support for TTrees.