Skip to content

{math}[foss/2018b] fix dependencies and configuration of CoinUtils ecosystem#10450

Merged
boegel merged 7 commits intoeasybuilders:developfrom
lexming:symphony
May 24, 2020
Merged

{math}[foss/2018b] fix dependencies and configuration of CoinUtils ecosystem#10450
boegel merged 7 commits intoeasybuilders:developfrom
lexming:symphony

Conversation

@lexming
Copy link
Copy Markdown
Contributor

@lexming lexming commented Apr 22, 2020

This PR fixes several issues with CoinUtils and packages depending on it

  • None of these packages is actually using the dependencies established in the easyconfig. All libraries are being rebuild again within each package, which translates to having, for instance, the libCoinUtils.so file replicated in the install path of CoinUtils, Osi, Clp, Cgl, and Cbg.
  • Most of these packages support BLAS/LAPACK but were not linking to it. Easyconfigs in foss/2018b are fixed and new ones are added into foss for those that were not in it.
  • These packages also support MPI, so I added the corresponding toolchainopts
  • Easyconfigs with GLPK as a dependency were not using it. Moreover, the packages that do support GLPK cannot use the GLPK installation from Easybuild because it is either to high a version or because they need the source files of GLPK. Therefore, this PR explicitly disables GLPK, because this is what is already being done and this will avoid potential issues if GLPK from EB is loaded in the environment.
  • Sanity checks have been revised

@lexming lexming added this to the 4.x milestone Apr 22, 2020
@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented Apr 22, 2020

Test report by @lexming
SUCCESS
Build succeeded for 7 out of 7 (7 easyconfigs in this PR)
node155.hydra.os - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) CPU E5-2680 v2 @ 2.80GHz, Python 2.7.5
See https://gist.github.com/53a57ffec2deeb9fe66e7c8927df5b1f for a full test report.

@lexming lexming modified the milestones: 4.x, next release (4.2.1?) Apr 24, 2020
@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented Apr 24, 2020 •
edited
Loading

Needed by #10058 and #10437

@lexming lexming mentioned this pull request Apr 30, 2020
Closed
@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 30, 2020

Test report by @boegel
SUCCESS
Build succeeded for 11 out of 11 (7 easyconfigs in this PR)
node3401.kirlia.os - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) Gold 6240 CPU @ 2.60GHz (cascadelake), Python 2.7.5
See https://gist.github.com/d57a3215421a04d5a1970e9aaa2a8b6b for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 30, 2020

Test report by @boegel
FAILED
Build succeeded for 6 out of 7 (7 easyconfigs in this PR)
generoso-1 - Linux centos linux 7.6.1810, x86_64, Intel(R) Xeon(R) CPU E5-2660 v4 @ 2.00GHz, Python 3.6.8
See https://gist.github.com/8e2ea7bdab8243f1d1002b0c577a1a81 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 30, 2020

Test report by @boegel
SUCCESS
Build succeeded for 10 out of 10 (7 easyconfigs in this PR)
node2608.swalot.os - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 2.7.5
See https://gist.github.com/15482fa89909017211eeec42ebc365cd for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 30, 2020

@lexming Any ideas on this failure?

make[2]: Entering directory `/tmp/kehoste/easybuild/build/Cbc/2.10.3/foss-2018b/Cbc-2.10.3/Cbc/src'
if /bin/sh ../../libtool --tag=CXX --mode=compile mpicxx -DHAVE_CONFIG_H -I. -I`echo .` -I../src  -I/work/maintainers/CO7/broadwell/software/Cbc/2.10.3-foss-2018b/include/coin -I/work/maintainers/CO7/broadwell/software/Clp/1.17.3-foss-2018b/include/coin     -DCOIN_NO_CLP_MESSAGE -DUSE_CBCCONFIG -I/work/maintainers/CO7/broadwell/software/zlib/1.2.11-GCCcore-7.3.0/include -I/work/maintainers/CO7/broadwell/software/bzip2/1.0.6-GCCcore-7.3.0/include -I/work/maintainers/CO7/broadwell/software/Cgl/0.60.2-foss-2018b/include -I/work/maintainers/CO7/broadwell/software/Clp/1.17.3-foss-2018b/include -I/work/maintainers/CO7/broadwell/software/Osi/0.108.5-foss-2018b/include -I/work/maintainers/CO7/broadwell/software/CoinUtils/2.11.3-foss-2018b/include -I/work/maintainers/CO7/broadwell/software/MUMPS/5.2.1-foss-2018b-metis/include -I/work/maintainers/CO7/broadwell/software/METIS/5.1.0-foss-2018b/include -I/work/maintainers/CO7/broadwell/software/FFTW/3.3.8-gompi-2018b/include -I/work/maintainers/CO7/broadwell/software/ScaLAPACK/2.0.2-gompi-2018b-OpenBLAS-0.3.1/include -I/work/maintainers/CO7/broadwell/software/OpenBLAS/0.3.1-GCC-7.3.0-2.30/include  -O2 -ftree-vectorize -march=native -fno-math-errno -fPIC   -DCBC_BUILD -MT CbcBranchAllDifferent.lo -MD -MP -MF ".deps/CbcBranchAllDifferent.Tpo" -c -o CbcBranchAllDifferent.lo CbcBranchAllDifferent.cpp; \
then mv -f ".deps/CbcBranchAllDifferent.Tpo" ".deps/CbcBranchAllDifferent.Plo"; else rm -f ".deps/CbcBranchAllDifferent.Tpo"; exit 1; fi
 mpicxx -DHAVE_CONFIG_H -I. -I. -I../src -I/work/maintainers/CO7/broadwell/software/Cbc/2.10.3-foss-2018b/include/coin -I/work/maintainers/CO7/broadwell/software/Clp/1.17.3-foss-2018b/include/coin -DCOIN_NO_CLP_MESSAGE -DUSE_CBCCONFIG -I/work/maintainers/CO7/broadwell/software/zlib/1.2.11-GCCcore-7.3.0/include -I/work/maintainers/CO7/broadwell/software/bzip2/1.0.6-GCCcore-7.3.0/include -I/work/maintainers/CO7/broadwell/software/Cgl/0.60.2-foss-2018b/include -I/work/maintainers/CO7/broadwell/software/Clp/1.17.3-foss-2018b/include -I/work/maintainers/CO7/broadwell/software/Osi/0.108.5-foss-2018b/include -I/work/maintainers/CO7/broadwell/software/CoinUtils/2.11.3-foss-2018b/include -I/work/maintainers/CO7/broadwell/software/MUMPS/5.2.1-foss-2018b-metis/include -I/work/maintainers/CO7/broadwell/software/METIS/5.1.0-foss-2018b/include -I/work/maintainers/CO7/broadwell/software/FFTW/3.3.8-gompi-2018b/include -I/work/maintainers/CO7/broadwell/software/ScaLAPACK/2.0.2-gompi-2018b-OpenBLAS-0.3.1/include -I/work/maintainers/CO7/broadwell/software/OpenBLAS/0.3.1-GCC-7.3.0-2.30/include -O2 -ftree-vectorize -march=native -fno-math-errno -fPIC -DCBC_BUILD -MT CbcBranchAllDifferent.lo -MD -MP -MF .deps/CbcBranchAllDifferent.Tpo -c CbcBranchAllDifferent.cpp  -fPIC -DPIC -o .libs/CbcBranchAllDifferent.o
CbcBranchAllDifferent.cpp:18:10: fatal error: OsiSolverInterface.hpp: No such file or directory
 #include "OsiSolverInterface.hpp"
          ^~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [CbcBranchAllDifferent.lo] Error 1

@smoors
Copy link
Copy Markdown
Contributor

smoors commented May 21, 2020

Test report by @smoors
SUCCESS
Build succeeded for 8 out of 8 (7 easyconfigs in this PR)
node302.hydra.os - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz (skylake_avx512), Python 2.7.5
See https://gist.github.com/9c39829398a2c48fb99a9ce0ad5dfd51 for a full test report.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented May 21, 2020

@boegel OsiSolverInterface.hpp should be in Osi/0.108.5-foss-2018b/include/coin/ and the include dir was added by @lexming in this PR for Cbc:

configopts += '--with-osi-incdir="$EBROOTOSI/include/coin -I$EBROOTCLP/include/coin" '

for some reason this include path is not picked up in your failed compilation.

@boegel
Copy link
Copy Markdown
Member

boegel commented May 24, 2020

Test report by @boegel
SUCCESS
Build succeeded for 7 out of 7 (7 easyconfigs in this PR)
generoso - Linux centos linux 7.6.1810, x86_64, Intel(R) Xeon(R) CPU E5-2660 v4 @ 2.00GHz, Python 3.6.8
See https://gist.github.com/5c1843cabc73ff2d5bcb64c81d3cd4b7 for a full test report.

boegel
boegel approved these changes May 24, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented May 24, 2020

@smoors Works fine after a new attempt, not sure what went wrong last time.

@boegel
Copy link
Copy Markdown
Member

boegel commented May 24, 2020

Going in, thanks @lexming!

@boegel boegel merged commit 71bfd73 into easybuilders:develop May 24, 2020
@lexming lexming deleted the symphony branch July 4, 2020 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.2.2

Development

Successfully merging this pull request may close these issues.

3 participants

@lexming @boegel @smoors