Skip to content

Fix missing const qualifiers for ncurses#10606

Merged
Micket merged 4 commits intoeasybuilders:developfrom
zao:20200509042318_new_pr_ncurses59
May 11, 2020
Merged

Fix missing const qualifiers for ncurses#10606
Micket merged 4 commits intoeasybuilders:developfrom
zao:20200509042318_new_pr_ncurses59

Conversation

@zao
Copy link
Copy Markdown
Contributor

@zao zao commented May 9, 2020

(created using eb --new-pr)
In order to build ncurses on Ubuntu 20.04's system compiler, some latent bugs regarding const qualification need to be fixed.

@Micket Micket added the bug fix label May 11, 2020
@Micket Micket added this to the next release (4.2.1?) milestone May 11, 2020
@Micket
Copy link
Copy Markdown
Contributor

Micket commented May 11, 2020

Test report by @Micket
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
hebbe-c1 - Linux centos linux 7.7.1908, Intel Core Processor (Haswell, no TSX), Python 2.7.5
See https://gist.github.com/da70a8ddf32049f01ae855d4ef1d56c2 for a full test report.

Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the description (and possibly author?) to the patch

@verdurin
Copy link
Copy Markdown
Member

Test report by @verdurin
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
easybuild.novalocal - Linux centos linux 7.8.2003, Intel Xeon Processor (Skylake, IBRS), Python 2.7.5
See https://gist.github.com/665896ac1acd744f152d00f7cffc7efd for a full test report.

@zao
Copy link
Copy Markdown
Contributor Author

zao commented May 11, 2020

I messed up the formatting of the patch description, please squash when merging to get rid of the silly intermediary commits.

Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Copy Markdown
Contributor

Micket commented May 11, 2020

Test report by @Micket
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
hebbe-c1 - Linux centos linux 7.7.1908, Intel Core Processor (Haswell, no TSX), Python 2.7.5
See https://gist.github.com/94c71215c22545d0b0ddef9700cd591b for a full test report.

@Micket Micket merged commit 0368af2 into easybuilders:develop May 11, 2020
@easybuilders easybuilders deleted a comment from boegelbot Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants