Skip to content

fix OS dependency for rstudio for Debian-based systems#10608

Merged
boegel merged 1 commit intoeasybuilders:developfrom
crubb:20200509085030_new_pr_rstudio125033
May 11, 2020
Merged

fix OS dependency for rstudio for Debian-based systems#10608
boegel merged 1 commit intoeasybuilders:developfrom
crubb:20200509085030_new_pr_rstudio125033

Conversation

@crubb
Copy link
Copy Markdown
Contributor

@crubb crubb commented May 9, 2020

(created using eb --new-pr)
Add libpam0g-dev to osdependencies

boegel
boegel reviewed May 11, 2020
View reviewed changes
Comment thread easybuild/easyconfigs/r/rstudio/rstudio-1.2.5033-fosscuda-2019b-Java-11.eb

osdependencies = ['pam-devel']
osdependencies = [
('pam-devel', 'libpam0g-dev')
Copy link
Copy Markdown
Member

@boegel boegel May 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crubb Is it worth adding an additional constant for this in framework, like we did for OpenSSL packages in easybuilders/easybuild-framework#3309 ?

@boegel boegel added the bug fix label May 11, 2020
@boegel boegel added this to the next release (4.2.1?) milestone May 11, 2020
@boegel boegel changed the title Fix building rstudio on .deb systems fix OS dependency for rstudio for Debian-based systems May 11, 2020
@boegel
Copy link
Copy Markdown
Member

boegel commented May 11, 2020

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
generoso - Linux centos linux 7.6.1810, x86_64, Intel(R) Xeon(R) CPU E5-2660 v4 @ 2.00GHz, Python 3.6.8
See https://gist.github.com/caa7596c3eee987ac337e92a8e752109 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented May 11, 2020

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node3301.joltik.os - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) Gold 6242 CPU @ 2.80GHz (cascadelake), Python 3.6.8
See https://gist.github.com/c505d651397f86188876807430765101 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented May 11, 2020

Going in, thanks @crubb!

@boegel boegel merged commit af9e63b into easybuilders:develop May 11, 2020
@crubb crubb mentioned this pull request May 11, 2020
Merged
@crubb crubb deleted the 20200509085030_new_pr_rstudio125033 branch May 11, 2020 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.2.1

Development

Successfully merging this pull request may close these issues.

2 participants

@crubb @boegel