Skip to content

update: libGLU source URL: use https#10686

Merged
Micket merged 2 commits intoeasybuilders:developfrom
asoete:10624_libGLU_https_io_ftp
May 29, 2020
Merged

update: libGLU source URL: use https#10686
Micket merged 2 commits intoeasybuilders:developfrom
asoete:10624_libGLU_https_io_ftp

Conversation

@asoete
Copy link
Copy Markdown
Contributor

@asoete asoete commented May 26, 2020

libGLU now has a https source available. The FTP source failed for me so
updating the easyconfigs to use https source instead of ftp.

closes gh-10624

libGLU now has a https source available. The FTP source failed for me so
updating the easyconfigs to use https source instead of ftp.

closes easybuildersgh-10624
@Micket Micket added the bug fix label May 26, 2020
@Micket Micket added this to the next release (4.2.2?) milestone May 26, 2020
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were sloppy back in the days, so many missing checksums. I hope I didn't make any mistakes in these suggestions.

Comment thread easybuild/easyconfigs/l/libGLU/libGLU-9.0.0-foss-2016a.eb
Comment thread easybuild/easyconfigs/l/libGLU/libGLU-9.0.0-gimkl-2.11.5.eb
Comment thread easybuild/easyconfigs/l/libGLU/libGLU-9.0.0-intel-2016a.eb
Comment thread easybuild/easyconfigs/l/libGLU/libGLU-9.0.0-intel-2016b.eb
Comment thread easybuild/easyconfigs/l/libGLU/libGLU-9.0.0-intel-2017a.eb
Comment thread easybuild/easyconfigs/l/libGLU/libGLU-9.0.0-intel-2017b.eb
Apply suggestions from code review

Co-authored-by: Mikael Öhman <[email protected]>
@asoete
Copy link
Copy Markdown
Contributor Author

asoete commented May 26, 2020

@Micket This is my first time submitting a PR like this. I hope I've done the correct thing by accepting your changes and committing them.

Kr.

@Micket
Copy link
Copy Markdown
Contributor

Micket commented May 26, 2020

Did only the source fetching step:
Test report by @Micket
SUCCESS
Build succeeded for 23 out of 23 (23 easyconfigs in this PR)
vera-c1 - Linux centos linux 7.7.1908, x86_64, Intel Xeon Processor (Skylake), Python 2.7.5
See https://gist.github.com/cca3702f0d26f2d307169cffa28039e5 for a full test report.

Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented May 27, 2020

close/re-open to wake up Travis, it seems like it was not informed of the last commit...

@boegel boegel closed this May 27, 2020
@boegel boegel reopened this May 27, 2020
@Micket Micket merged commit f3d3c30 into easybuilders:develop May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

libGLU source URL has an https option

3 participants