Skip to content

{bio}[foss/2019b] GraPhlAn v1.1.3 w/ Python 2.7.16#10707

Merged
smoors merged 3 commits intoeasybuilders:developfrom
DeepThoughtHPC:20200528153347_new_pr_GraPhlAn113
Dec 17, 2020
Merged

{bio}[foss/2019b] GraPhlAn v1.1.3 w/ Python 2.7.16#10707
smoors merged 3 commits intoeasybuilders:developfrom
DeepThoughtHPC:20200528153347_new_pr_GraPhlAn113

Conversation

@manifestoso
Copy link
Copy Markdown
Contributor

@manifestoso manifestoso commented May 28, 2020

(created using eb --new-pr)

akesandgren
akesandgren previously requested changes Jun 4, 2020
View reviewed changes
Comment thread easybuild/easyconfigs/g/GraPhlAn/GraPhlAn-1.1.3-foss-2019b-Python-2.7.16.eb Outdated
@manifestoso
Copy link
Copy Markdown
Contributor Author

manifestoso commented Sep 10, 2020

@akesandgren sanity check and merge this PR?

@easybuilders easybuilders deleted a comment from boegelbot Nov 16, 2020
smoors
smoors requested changes Nov 16, 2020
View reviewed changes
Comment thread easybuild/easyconfigs/g/GraPhlAn/GraPhlAn-1.1.3-foss-2019b-Python-2.7.16.eb Outdated
@manifestoso
Copy link
Copy Markdown
Contributor Author

manifestoso commented Nov 25, 2020 •
edited
Loading

change committed. Thx @smoors

@manifestoso manifestoso requested a review from smoors November 25, 2020 23:15
@manifestoso
Copy link
Copy Markdown
Contributor Author

manifestoso commented Dec 16, 2020

@boegel @smoors Can we check and merge this PR?

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Dec 17, 2020

@boegelbot please test @ generoso

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Dec 17, 2020

Test report by @smoors
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node374.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz (skylake_avx512), Python 2.7.5
See https://gist.github.com/77c8794a3f41dd2bbdf7e363521ebe89 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 17, 2020

@smoors: Request for testing this PR well received on generoso

PR test command 'EB_PR=10707 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_10707 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12312

Test results coming soon (I hope)...

Details

- notification for comment with ID 747286258 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 17, 2020

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
generoso-c1-s-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/3e68994286b7225dbf7e834a039b8989 for a full test report.

@smoors smoors added the new label Dec 17, 2020
@smoors smoors added this to the next release (4.3.3?) milestone Dec 17, 2020
smoors
smoors approved these changes Dec 17, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Dec 17, 2020

Going in, thanks @robqiao!

@smoors smoors merged commit 82206c4 into easybuilders:develop Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smoors smoors smoors approved these changes

@akesandgren akesandgren Awaiting requested review from akesandgren

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

4.3.3

Development

Successfully merging this pull request may close these issues.

4 participants

@manifestoso @smoors @boegelbot @akesandgren