Skip to content

{numlib}[foss/2018b] Armadillo v9.600.5#10812

Merged
smoors merged 4 commits intoeasybuilders:developfrom
tstrempel:20200615112027_new_pr_Armadillo96005
Jun 25, 2020
Merged

{numlib}[foss/2018b] Armadillo v9.600.5#10812
smoors merged 4 commits intoeasybuilders:developfrom
tstrempel:20200615112027_new_pr_Armadillo96005

Conversation

@tstrempel
Copy link
Copy Markdown
Contributor

(created using eb --new-pr)

@tstrempel
Copy link
Copy Markdown
Contributor Author

The patch is needed, because if you have mkl installed in /opt or a standard location, mkl will be chosen above OpenBLAS.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Jun 22, 2020

@tstrempel is this patch needed for the more recent versions as well?
Armadillo-9.700.2-foss-2019a.eb, Armadillo-9.880.1-foss-2020a.eb

if so, would you mind updating those easyconfigs as well?

@tstrempel
Copy link
Copy Markdown
Contributor Author

tstrempel commented Jun 23, 2020

@smoors Yes, it is needed. I'll also provide a version for 2019b. I just didn't want to commit the same file 4 times as I didn't know how this would be handeled.
Is it allowed to commit multiple EasyConfigs in one pull request?

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Jun 24, 2020

Is it allowed to commit multiple EasyConfigs in one pull request?

yes, you can upload multiple easyconfigs in one PR, although it's a good idea to limit the number of easyconfigs to max 10 to ease the review process.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Jun 25, 2020

@tstrempel protip: it looks like you are manually updating the checksums?
that's not needed, you can let EB do it for you:

eb --inject-checksums --force Armadillo-9.880.1-foss-2020a.eb

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Jun 25, 2020

Test report by @smoors
SUCCESS
Build succeeded for 8 out of 8 (4 easyconfigs in this PR)
node358.hydra.os - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz (skylake_avx512), Python 2.7.5
See https://gist.github.com/d6e185c32515dec8aa7ba1e3ee98e7f1 for a full test report.

Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Jun 25, 2020

Going in, thanks @tstrempel!

@smoors smoors merged commit 992b661 into easybuilders:develop Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants