add patch for PyQtGraph to fix exporting images#10848
add patch for PyQtGraph to fix exporting images#10848lexming merged 4 commits intoeasybuilders:developfrom
Conversation
lexming
left a comment
There was a problem hiding this comment.
Thanks for submitting this patch. Would it be possible to add it to all easyconfigs of PyQtGraph and not only to 2018a?
The tests fail because there have been some changes in our requirements for easyconfigs. Now all PythonPackage should have sanity_pip_check = True.
Moreover, the current sanity_check_paths of this easyconfig are now default, so those could be removed.
lexming
left a comment
There was a problem hiding this comment.
Thanks for updating the PR. I revised the patch and I think that it is safer to use the same approach found in PyQtGraph v0.11.0, as it converts to int before the conditional check. Otherwise values between 0 and 1 could cause issues.
|
Just as a reminder: updating the patch file implies updating the checksum for the patch file as well. @lexming With that in mind, maybe it's easier to send a proper PR to @SimonPinches' branch used for this PR, rather than using the suggestions feature? |
|
@boegel you are right, I totally forgot about the checksum. I'll make a PR |
|
@SimonPinches I made a PR into the branch of this PR with my suggestions, so you can easily incorporate them. Please check SimonPinches#14 |
Update PyQtGraph-0.10.0-ImageExporter.patch
|
Thanks @lexming. |
|
Test report by @lexming |
|
Going in, thanks @SimonPinches ! |
(created using
eb --new-pr)