Skip to content

fix source URLs in Eigen 3.3.* easyconfigs#10869

Merged
zao merged 2 commits intoeasybuilders:developfrom
boegel:20200626201441_new_pr_Eigen332
Jun 26, 2020
Merged

fix source URLs in Eigen 3.3.* easyconfigs#10869
zao merged 2 commits intoeasybuilders:developfrom
boegel:20200626201441_new_pr_Eigen332

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Jun 26, 2020

(created using eb --new-pr)
fixes part of #10868

@boegel boegel added this to the next release (4.2.2?) milestone Jun 26, 2020
@boegel boegel added the bug fix label Jun 26, 2020
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jun 26, 2020

Checksums have changed, but actual sources have not:

$ diff -ru eigen-eigen-5a0156e40feb eigen-3.3.4
Only in eigen-eigen-5a0156e40feb: .hg_archival.txt
Only in eigen-eigen-5a0156e40feb: .hgtags
$

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jun 26, 2020

Test report by @boegel
SUCCESS
Build succeeded for 8 out of 8 (8 easyconfigs in this PR)
node2400.golett.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz (haswell), Python 2.7.5
See https://gist.github.com/71c6b183f5efd9dadfeb4aeee84ac6c5 for a full test report.

zao
zao approved these changes Jun 26, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@zao zao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initially wondered if we should keep the original checksum, but the filenames differ so it doesn't matter in this case.

LGTM

@zao
Copy link
Copy Markdown
Contributor

zao commented Jun 26, 2020

Going in, thanks @boegel!

@zao zao merged commit 8de9e6b into easybuilders:develop Jun 26, 2020
@boegel boegel deleted the 20200626201441_new_pr_Eigen332 branch June 26, 2020 19:35
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jun 26, 2020

Initially wondered if we should keep the original checksum, but the filenames differ so it doesn't matter in this case.

Indeed, that was my initial intention, but it doesn't make sense since the filenames are different.

@boegel boegel mentioned this pull request Jun 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zao zao zao approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.2.2

Development

Successfully merging this pull request may close these issues.

2 participants

@boegel @zao