Skip to content

switch to github.com source URL for MetaPhlAn#10874

Merged
zao merged 3 commits intoeasybuilders:developfrom
boegel:20200627104840_new_pr_MetaPhlAn2278
Jun 27, 2020
Merged

switch to github.com source URL for MetaPhlAn#10874
zao merged 3 commits intoeasybuilders:developfrom
boegel:20200627104840_new_pr_MetaPhlAn2278

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Jun 27, 2020

(created using eb --new-pr)
fixes part of #10868

@boegel boegel mentioned this pull request Jun 27, 2020
Closed
@boegel boegel added the bug fix label Jun 27, 2020
@boegel boegel added this to the next release (4.2.2?) milestone Jun 27, 2020
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jun 27, 2020

Different checksum, but no source file changes, so can retain both SHA256 checksums as valid:

$ diff -ru biobakery-metaphlan2-9760413b180f MetaPhlAn-2.7.8
Only in biobakery-metaphlan2-9760413b180f: .hg_archival.txt
Only in biobakery-metaphlan2-9760413b180f: .hgtags

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jun 27, 2020

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node2405.golett.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz (haswell), Python 2.7.5
See https://gist.github.com/61a038b710f6dea90aae8f9aa7f5bd97 for a full test report.

zao
zao requested changes Jun 27, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@zao zao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Different checksum, but no source file changes, so can retain both SHA256 checksums as valid:

Shouldn't both checksums be present in the easyconfigs then?

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jun 27, 2020

Different checksum, but no source file changes, so can retain both SHA256 checksums as valid:

Shouldn't both checksums be present in the easyconfigs then?

Yup, totally. I had it set up to do that at first, but overlooked retaining that when I had to add the patch, fixing that now...

zao
zao previously approved these changes Jun 27, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@zao zao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jun 27, 2020

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node2405.golett.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz (haswell), Python 2.7.5
See https://gist.github.com/b133e51fac1c3d74622c81deee215df4 for a full test report.

@zao
Copy link
Copy Markdown
Contributor

zao commented Jun 27, 2020

Style check has opinions about your indentation.

@easybuilders easybuilders deleted a comment from boegelbot Jun 27, 2020
zao
zao approved these changes Jun 27, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@zao zao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zao
Copy link
Copy Markdown
Contributor

zao commented Jun 27, 2020

Going in, thanks @boegel!

@zao zao merged commit 7bf822c into easybuilders:develop Jun 27, 2020
@boegel boegel deleted the 20200627104840_new_pr_MetaPhlAn2278 branch June 27, 2020 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zao zao zao approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.2.2

Development

Successfully merging this pull request may close these issues.

2 participants

@boegel @zao