Skip to content

switch to GitHub sources for ScientificPython 2.9.4#10875

Merged
zao merged 3 commits intoeasybuilders:developfrom
boegel:20200627113343_new_pr_ScientificPython294
Jun 27, 2020
Merged

switch to GitHub sources for ScientificPython 2.9.4#10875
zao merged 3 commits intoeasybuilders:developfrom
boegel:20200627113343_new_pr_ScientificPython294

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Jun 27, 2020

(created using eb --new-pr)

@boegel boegel mentioned this pull request Jun 27, 2020
Closed
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jun 27, 2020

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node2405.golett.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz (haswell), Python 2.7.5
See https://gist.github.com/465e92182bad1041c1020ab14f82db20 for a full test report.

@boegel boegel added the bug fix label Jun 27, 2020
@boegel boegel added this to the next release (4.2.2?) milestone Jun 27, 2020
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jun 27, 2020

I'll need to allow using sanity_pip_check = False here too, so waiting until #10873 gets merged to avoid introducing conflicts...

@easybuilders easybuilders deleted a comment from boegelbot Jun 27, 2020
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jun 27, 2020

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node2405.golett.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz (haswell), Python 2.7.5
See https://gist.github.com/9bd43e9b1fe66cad9b3b9b08dc78659c for a full test report.

zao
zao approved these changes Jun 27, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@zao zao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zao
Copy link
Copy Markdown
Contributor

zao commented Jun 27, 2020

Going in, thanks @boegel!

@zao zao merged commit 36c1a55 into easybuilders:develop Jun 27, 2020
@boegel boegel deleted the 20200627113343_new_pr_ScientificPython294 branch June 28, 2020 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zao zao zao approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.2.2

Development

Successfully merging this pull request may close these issues.

2 participants

@boegel @zao