Skip to content

fix sanity_check_paths in CFITSIO-3.48-GCCcore-9.3.0.eb easyconfig#10917

Merged
bartoldeman merged 1 commit intoeasybuilders:developfrom
lexming:20200705022031_new_pr_CFITSIO348
Jul 5, 2020
Merged

fix sanity_check_paths in CFITSIO-3.48-GCCcore-9.3.0.eb easyconfig#10917
bartoldeman merged 1 commit intoeasybuilders:developfrom
lexming:20200705022031_new_pr_CFITSIO348

Conversation

@lexming
Copy link
Copy Markdown
Contributor

@lexming lexming commented Jul 5, 2020

(created using eb --new-pr)

@lexming lexming added the bug fix label Jul 5, 2020
@lexming lexming added this to the 4.x milestone Jul 5, 2020
@lexming lexming changed the title fix sanity_check_paths of CFITSIO-3.48-GCCcore-9.3.0.eb {lib}[GCCcore/9.3.0] fix sanity_check_paths of CFITSIO-3.48-GCCcore-9.3.0.eb Jul 5, 2020
@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented Jul 5, 2020

Test report by @lexming
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node125.hydra.os - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) CPU E5-2680 v2 @ 2.80GHz, Python 2.7.5
See https://gist.github.com/3c3d77a3f074cb5040a94104853a2923 for a full test report.

@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented Jul 5, 2020

Test report by @lexming
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node381.hydra.os - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/4731a7991f33d51067f7ab66040eb197 for a full test report.

@bartoldeman
Copy link
Copy Markdown
Contributor

@lexming just curious what problem does this fix, as the test builds succeeded?

@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented Jul 5, 2020

@bartoldeman it's a compatibility issue with non-linux systems

@bartoldeman
Copy link
Copy Markdown
Contributor

Test report by @bartoldeman
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
build-node.computecanada.ca - Linux centos linux 7.8.2003, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.7.7
See https://gist.github.com/f807306a12e2acd0630df0461030968b for a full test report.

Copy link
Copy Markdown
Contributor

@bartoldeman bartoldeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bartoldeman
Copy link
Copy Markdown
Contributor

Going in, thanks @lexming!

@bartoldeman bartoldeman merged commit 2ee5ff6 into easybuilders:develop Jul 5, 2020
@lexming lexming deleted the 20200705022031_new_pr_CFITSIO348 branch July 6, 2020 07:41
@boegel boegel modified the milestones: 4.x, 4.2.2 Jul 6, 2020
@boegel boegel changed the title {lib}[GCCcore/9.3.0] fix sanity_check_paths of CFITSIO-3.48-GCCcore-9.3.0.eb fix sanity_check_paths in CFITSIO-3.48-GCCcore-9.3.0.eb easyconfig Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants