Skip to content

use CMakeMake easyblock for installing magma to avoid C++11 related failures on Power#10929

Merged
migueldiascosta merged 1 commit intoeasybuilders:developfrom
Flamefire:20200707164511_new_pr_magma251
Jul 15, 2020
Merged

use CMakeMake easyblock for installing magma to avoid C++11 related failures on Power#10929
migueldiascosta merged 1 commit intoeasybuilders:developfrom
Flamefire:20200707164511_new_pr_magma251

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

(created using eb --new-pr)

@Flamefire
Copy link
Copy Markdown
Contributor Author

Test report by @Flamefire
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
taurusml6 - Linux RHEL 7.6, POWER, 8335-GTX, Python 2.7.5
See https://gist.github.com/4cd64601f1cefc56dedb19a6cad9fc92 for a full test report.

@Flamefire
Copy link
Copy Markdown
Contributor Author

@boegel Can this be added to the next release as a bugfix please? It allows building it on power

@Flamefire
Copy link
Copy Markdown
Contributor Author

Test report by @Flamefire
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
taurusi4189.taurus.hrsk.tu-dresden.de - Linux RHEL 7.8, x86_64, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/3d5579ea46c533c41db96eec45f7ff95 for a full test report.

@migueldiascosta
Copy link
Copy Markdown
Member

Test report by @migueldiascosta
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
sms - Linux centos linux 7.6.1810, x86_64, AMD EPYC 7601 32-Core Processor (zen), Python 2.7.5
See https://gist.github.com/1b76bbafde3f138deba193c7656085d2 for a full test report.

@migueldiascosta
Copy link
Copy Markdown
Member

lgtm, but since the tests pass on a system without GPUs, I suppose the testsuite is not being run (?)

worth looking into running the testsuite?

@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Jul 15, 2020

As far as I can tell no tests were run before except compile tests due to lack of runtest in the EC. If those tests only succeed on GPU then they shouldn't be run as the build nodes might not have GPUs. I think this is done like this everywhere else

Anyway I checked the CMakeLists and there are no tests added that could be executed by make test or the like. I've seen run_test: test\n cd testing && python ./run_tests.py in the Makefile which might work. However it doesn't exit with an error code on failure so we'd need to grep the output -.- Not really keen on that and as mentioned: If they won't pass on non-GPU nodes I'd rather not do that.

Edit: Oh and the use of python means we'd need Python at least as a build dependency. Kinda OK I guess.

@migueldiascosta
Copy link
Copy Markdown
Member

I think in same cases (e.g. TensorFlow?), when particularly relevant (as it would be for magma, imho), we do run the GPU tests, but indeed I'm not sure, this is only based on occasionally not being able to build on non-GPU systems

but if it doesn't have a proper testsuite, my question is irrelevant :)

Copy link
Copy Markdown
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@migueldiascosta
Copy link
Copy Markdown
Member

Going in, thanks @Flamefire!

@migueldiascosta migueldiascosta merged commit a257554 into easybuilders:develop Jul 15, 2020
@Flamefire Flamefire deleted the 20200707164511_new_pr_magma251 branch July 15, 2020 11:30
@boegel boegel changed the title [magma] Use CMakeMake to avoid C++11 related failures on Power use CMakeMake easyblock for installing magma to avoid C++11 related failures on Power Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants