Skip to content

{vis}[intel/2018a, foss/2018b] fix source URL for Graphviz v2.40.1#10944

Merged
verdurin merged 1 commit intoeasybuilders:developfrom
lexming:20200709003446_new_pr_Graphviz2401
Sep 10, 2020
Merged

{vis}[intel/2018a, foss/2018b] fix source URL for Graphviz v2.40.1#10944
verdurin merged 1 commit intoeasybuilders:developfrom
lexming:20200709003446_new_pr_Graphviz2401

Conversation

@lexming
Copy link
Copy Markdown
Contributor

@lexming lexming commented Jul 8, 2020

(created using eb --new-pr)

The download URL from fossies.org no longer exists. Since the official download still lacks versioning, I propose to use the same solution from our friends in Spack (I won't say it too loud) and take the sources from the release commit of v2.40.1 in the project's gitlab.

I modified the easyconfig so that it works with both the old sources from fossies and the new ones from gitlab. Checksums for both tarballs are present and the extract_cmd ensures that patches do not get confused.

The updated patch file removes changes related to a Makefile.in generated by autotools. That file is overwritten by autogen.sh in the original sources (no need to patch) and it does not exists in the sources from gitlab.

@lexming lexming changed the title fix source URL for Graphviz v2.40.1 {vis}[intel/2018a, foss/2018b] fix source URL for Graphviz v2.40.1 Jul 8, 2020
@lexming lexming added the bug fix label Jul 8, 2020
@lexming lexming added this to the 4.x milestone Jul 8, 2020
@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented Jul 9, 2020

Test report by @lexming
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
node125.hydra.os - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) CPU E5-2680 v2 @ 2.80GHz, Python 2.7.5
See https://gist.github.com/09561953d2a2e71063f45ef4ec856fb6 for a full test report.

@boegel boegel modified the milestones: 4.x, next release (4.3.0) Sep 9, 2020
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 10, 2020

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
node3109.skitty.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/a001e3b84de3629e3331b10289f486f8 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 10, 2020

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
node2403.golett.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz (haswell), Python 2.7.5
See https://gist.github.com/7b049cd589f60dda87859288b434c006 for a full test report.

@verdurin
Copy link
Copy Markdown
Member

Going in, thanks @lexming!

@verdurin verdurin merged commit a8a60a3 into easybuilders:develop Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants