Skip to content

add missing dependencies for OpenPIV + switch to PythonBundle easyblock and include progressbar2 as extension#11096

Merged
smoors merged 3 commits intoeasybuilders:developfrom
boegel:20200811195642_new_pr_OpenPIV0218
Aug 12, 2020
Merged

add missing dependencies for OpenPIV + switch to PythonBundle easyblock and include progressbar2 as extension#11096
smoors merged 3 commits intoeasybuilders:developfrom
boegel:20200811195642_new_pr_OpenPIV0218

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Aug 11, 2020 •
edited
Loading

(created using eb --new-pr)
missing deps uncovered by fixed bug in easyblock (see easybuilders/easybuild-easyblocks#2114)

edit: note: make sure you have an updated Python installation, since dask required sortedcontainers to be included (see #10969)

@boegel boegel added the update label Aug 11, 2020
@boegel boegel mentioned this pull request Aug 11, 2020
Merged
5 tasks
@boegel boegel added this to the next release (4.2.3?) milestone Aug 11, 2020
@boegel boegel added bug fix and removed update labels Aug 11, 2020
@easybuilders easybuilders deleted a comment from boegelbot Aug 11, 2020
@boegel boegel requested a review from smoors August 11, 2020 19:06
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Aug 11, 2020

Test report by @boegel
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in this PR)
node3151.skitty.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/211ea5debaf5d5e25974379e167980d5 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Aug 11, 2020

Test report by @boegel
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in this PR)
generoso - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/fcdcd07de68d7e76c1703622b25023d4 for a full test report.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Aug 12, 2020

Test report by @smoors
FAILED
Build succeeded for 3 out of 6 (5 easyconfigs in this PR)
node254.hydra.os - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) CPU E5-2683 v4 @ 2.10GHz (broadwell), Python 2.7.5
See https://gist.github.com/84434cb3525e349489482aae209c5cd8 for a full test report.

@migueldiascosta
Copy link
Copy Markdown
Member

migueldiascosta commented Aug 12, 2020

Test report by @migueldiascosta
FAILED
Build succeeded for 2 out of 5 (5 easyconfigs in this PR)
sms - Linux centos linux 7.6.1810, x86_64, AMD EPYC 7601 32-Core Processor (zen), Python 2.7.5
See https://gist.github.com/510326ec7a3bf9b164bb65958d26d76f for a full test report.

@migueldiascosta
Copy link
Copy Markdown
Member

migueldiascosta commented Aug 12, 2020

Test report by @migueldiascosta
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in this PR)
sms - Linux centos linux 7.6.1810, x86_64, AMD EPYC 7601 32-Core Processor (zen), Python 2.7.5
See https://gist.github.com/240733993084402e6b56a546c85069d2 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Aug 12, 2020

@smoors You need to make sure your Python installation includes sortedcontainers, see note in PR descr.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Aug 12, 2020

Test report by @smoors
SUCCESS
Build succeeded for 6 out of 6 (5 easyconfigs in this PR)
node253.hydra.os - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) CPU E5-2650 v4 @ 2.20GHz (broadwell), Python 2.7.5
See https://gist.github.com/9dc532a4c58acbfe08e38e4f317beca7 for a full test report.

smoors
smoors approved these changes Aug 12, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Aug 12, 2020

Going in, thanks @boegel!

@smoors smoors merged commit 228a818 into easybuilders:develop Aug 12, 2020
@boegel boegel deleted the 20200811195642_new_pr_OpenPIV0218 branch August 12, 2020 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smoors smoors smoors approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @smoors @migueldiascosta