Skip to content

add missing pkg-config build dep in Octave 5.1.0 easyconfigs#11100

Merged
smoors merged 1 commit intoeasybuilders:developfrom
boegel:20200812144136_new_pr_Octave510
Aug 14, 2020
Merged

add missing pkg-config build dep in Octave 5.1.0 easyconfigs#11100
smoors merged 1 commit intoeasybuilders:developfrom
boegel:20200812144136_new_pr_Octave510

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Aug 12, 2020

(created using eb --new-pr)
this fixes a symbol lookup error when installing control extension:

/lib/octave/5.1.0/liboctinterp.so.7: undefined symbol: jpeg_resync_to_restart

cc @terjekv

@boegel boegel added the bug fix label Aug 12, 2020
@boegel boegel added this to the next release (4.2.3?) milestone Aug 12, 2020
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Aug 12, 2020

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
generoso-x-5 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/e02d1c0dbf82be55bec7e88eef0fa3c8 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Aug 12, 2020

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node3401.kirlia.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6240 CPU @ 2.60GHz (cascadelake), Python 2.7.5
See https://gist.github.com/3e467f48e8866ff930a66e7fdad38bbd for a full test report.

@terjekv
Copy link
Copy Markdown
Collaborator

terjekv commented Aug 12, 2020

Test report by @terjekv
FAILED
Build succeeded for 31 out of 32 (2 easyconfigs in this PR)
ninhursaga.uio.no - Linux RHEL 8.2, x86_64, Intel(R) Xeon(R) Silver 4216 CPU @ 2.10GHz, Python 3.6.8
See https://gist.github.com/68140ff9595ae31a5fe3bf9a4a883f8a for a full test report.

@terjekv
Copy link
Copy Markdown
Collaborator

terjekv commented Aug 12, 2020

Test report by @terjekv
SUCCESS
Build succeeded for 0 out of 0 (2 easyconfigs in this PR)
ninhursaga.uio.no - Linux RHEL 8.2, x86_64, Intel(R) Xeon(R) Silver 4216 CPU @ 2.10GHz, Python 3.6.8
See https://gist.github.com/16fcf5aec6d66a73a88624a6334c6fa4 for a full test report.

@terjekv
Copy link
Copy Markdown
Collaborator

terjekv commented Aug 12, 2020

I have no idea what failed...

== packaging...
== COMPLETED: Installation ended successfully (took 14 min 18 sec)
== Results of the build can be found in the log file(s) /tmp/terjekv/tmp-installs/11100/software/Octave/5.1.0-foss-2019a/easybuild/easybuild-Octave-5.1.0-20200812.173641.log
Adding comment to easybuild-easyconfigs issue #11100: 'Test report by @terjekv
**FAILED**
Build succeeded for 31 out of 32 (2 easyconfigs in this PR)
ninhursaga.uio.no - Linux RHEL 8.2, x86_64, Intel(R) Xeon(R) Silver 4216 CPU @ 2.10GHz, Python 3.6.8
See https://gist.github.com/68140ff9595ae31a5fe3bf9a4a883f8a for a full test report.'
== Test report uploaded to https://gist.github.com/68140ff9595ae31a5fe3bf9a4a883f8a and mentioned in a comment in easyconfigs PR#11100
== Build succeeded for 31 out of 32

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Aug 14, 2020

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 14, 2020

@smoors: Request for testing this PR well received on generoso

PR test command 'EB_PR=11100 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_11100 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4984

Test results coming soon (I hope)...

Details

- notification for comment with ID 674041730 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Aug 14, 2020

@smoors I already submitted a test report from generoso for this, but once more doesn't hurt I guess... ;)

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Aug 14, 2020

I have no idea what failed...

See https://gist.github.com/terjekv/68140ff9595ae31a5fe3bf9a4a883f8a, looks like a disk space issue perhaps, or something blowing away the build directory while it was still running?

Doesn't matter much, 2nd test report confirms it works.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Aug 14, 2020

@smoors I already submitted a test report from generoso for this, but once more doesn't hurt I guess... ;)

ah indeed, thanks for pointing that out.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 14, 2020

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
generoso-x-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/eee510d111fee1e92fd92368950871ca for a full test report.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Aug 14, 2020

Test report by @smoors
SUCCESS
Build succeeded for 13 out of 13 (2 easyconfigs in this PR)
node254.hydra.os - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) CPU E5-2683 v4 @ 2.10GHz (broadwell), Python 2.7.5
See https://gist.github.com/90ffce32f04fc7141fe8634b690f8a85 for a full test report.

smoors
smoors approved these changes Aug 14, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Aug 14, 2020

Going in, thanks @boegel!

@smoors smoors merged commit 7dc0bb3 into easybuilders:develop Aug 14, 2020
@boegel boegel deleted the 20200812144136_new_pr_Octave510 branch August 14, 2020 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smoors smoors smoors approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.3.0

Development

Successfully merging this pull request may close these issues.

4 participants

@boegel @terjekv @smoors @boegelbot