Skip to content

{vis}[GCC/9.3.0] BioPP v2.4.1#11113

Merged
smoors merged 2 commits intoeasybuilders:developfrom
mboisson:20200813210259_new_pr_BioPP241
Aug 14, 2020
Merged

{vis}[GCC/9.3.0] BioPP v2.4.1#11113
smoors merged 2 commits intoeasybuilders:developfrom
mboisson:20200813210259_new_pr_BioPP241

Conversation

@mboisson
Copy link
Copy Markdown
Contributor

@mboisson mboisson commented Aug 13, 2020

(created using eb --new-pr)

@mboisson
Copy link
Copy Markdown
Contributor Author

mboisson commented Aug 13, 2020

This replaces
https://github.com/easybuilders/easybuild-easyconfigs/tree/develop/easybuild/easyconfigs/b/bpp-core
https://github.com/easybuilders/easybuild-easyconfigs/tree/develop/easybuild/easyconfigs/b/bpp-phyl
https://github.com/easybuilders/easybuild-easyconfigs/tree/develop/easybuild/easyconfigs/b/bpp-seq

and more. My understanding is that this is all a suite, so I install all of the parts within a single bundle.

@mboisson mboisson mentioned this pull request Aug 13, 2020
Merged
@smoors
Copy link
Copy Markdown
Contributor

smoors commented Aug 14, 2020

Test report by @smoors
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node254.hydra.os - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) CPU E5-2683 v4 @ 2.10GHz (broadwell), Python 2.7.5
See https://gist.github.com/fa40064066e5b0e7b55f6204c9cf9dc3 for a full test report.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Aug 14, 2020

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 14, 2020

@smoors: Request for testing this PR well received on generoso

PR test command 'EB_PR=11113 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_11113 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4985

Test results coming soon (I hope)...

Details

- notification for comment with ID 674041396 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 14, 2020

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
generoso-x-2 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/08e1cc599456a8a7c4abf4149d9dc8c5 for a full test report.

@mboisson mboisson mentioned this pull request Aug 14, 2020
Open
@smoors smoors added the new label Aug 14, 2020
@smoors smoors added this to the next release (4.2.3?) milestone Aug 14, 2020
smoors
smoors approved these changes Aug 14, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mboisson
Copy link
Copy Markdown
Contributor Author

mboisson commented Aug 14, 2020

What should be done with the existing bpp-core, bpp-phyl, bpp-seq ?

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Aug 14, 2020

Going in, thanks @mboisson!

@smoors smoors merged commit 49b634b into easybuilders:develop Aug 14, 2020
@mboisson mboisson deleted the 20200813210259_new_pr_BioPP241 branch August 14, 2020 12:24
@smoors
Copy link
Copy Markdown
Contributor

smoors commented Aug 14, 2020

What should be done with the existing bpp-core, bpp-phyl, bpp-seq ?

since no other software depends on them, I think we should remove them?

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Aug 14, 2020

@boegel ^

@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 15, 2020

Different toolchain, so unless we add a bundle using GCC-8.2.0-2.31 as a toolchain, we shouldn't remove those just yet.

@mboisson
Copy link
Copy Markdown
Contributor Author

mboisson commented Aug 17, 2020

I can create a PR for that toolchain, but I can't test it as we don't have it installed. Let me know if you want me to do so. @boegel

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 22, 2020

@mboisson Cleaning that up makes sense to me, we can take care of the test report(s)

mboisson added a commit to mboisson/easybuild-easyconfigs that referenced this pull request Nov 3, 2020
@mboisson
Reorganizing BioPP for toolchain GCC-8.2.0-2.31.1 as discussed in PR e…
40633ec 
…asybuilders#11113
mboisson added a commit to mboisson/easybuild-easyconfigs that referenced this pull request Nov 3, 2020
@mboisson
Reorganizing BioPP for toolchain GCC-8.2.0-2.31.1 as discussed in PR e…
450b23a 
…asybuilders#11113
mboisson added a commit to mboisson/easybuild-easyconfigs that referenced this pull request Nov 3, 2020
@mboisson
Reorganizing BioPP for toolchain GCC-8.2.0-2.31.1 as discussed in PR e…
08fb163 
…asybuilders#11113
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smoors smoors smoors approved these changes

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

4.3.0

Development

Successfully merging this pull request may close these issues.

4 participants

@mboisson @smoors @boegelbot @boegel