Skip to content

add missing Keras-Applications extension to TensorFlow 2.2.0 easyconfigs with foss*/2019b toolchain#11156

Merged
lexming merged 1 commit intoeasybuilders:developfrom
boegel:20200821121912_new_pr_TensorFlow220
Aug 26, 2020
Merged

add missing Keras-Applications extension to TensorFlow 2.2.0 easyconfigs with foss*/2019b toolchain#11156
lexming merged 1 commit intoeasybuilders:developfrom
boegel:20200821121912_new_pr_TensorFlow220

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Aug 21, 2020 •
edited
Loading

(created using eb --new-pr)

This fixes an import error that happens with some applications depending on this missing extension (which is already included with other TensorFlow easyconfigs):

ModuleNotFoundError: No module named 'keras_applications'

@boegel boegel added the bug fix label Aug 21, 2020
@boegel boegel added this to the next release (4.3.0) milestone Aug 21, 2020
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Aug 21, 2020

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 21, 2020

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=11156 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_11156 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5095

Test results coming soon (I hope)...

Details

- notification for comment with ID 678188761 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Aug 21, 2020

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node3105.skitty.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/30029c29322332bc707c20135178eda9 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Aug 21, 2020

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node2560.golett.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz (haswell), Python 2.7.5
See https://gist.github.com/f58cda9ed8b4ca7d66798cb0d696cecf for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 21, 2020

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
generoso-x-2 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/f31a9d6e57b0e2990441407b989ff088 for a full test report.

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Aug 25, 2020

Test report by @lexming
SUCCESS
Build succeeded for 3 out of 3 (1 easyconfigs in this PR)
node358.hydra.os - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/dc955d41b601e8a10166c47cf55dd50f for a full test report.

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Aug 25, 2020

Test report by @lexming
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node120.hydra.os - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) CPU E5-2680 v2 @ 2.80GHz, Python 2.7.5
See https://gist.github.com/93d214d48cf928d99c4ab643fe0874ea for a full test report.

lexming
lexming approved these changes Aug 26, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Aug 26, 2020

Going in, thanks @boegel !

@lexming lexming merged commit 91bedd1 into easybuilders:develop Aug 26, 2020
@lexming
Copy link
Copy Markdown
Contributor

lexming commented Aug 26, 2020

Test report by @lexming
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node154.hydra.os - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) CPU E5-2680 v2 @ 2.80GHz, Python 2.7.5
See https://gist.github.com/734950b569533fe3e4b6e415aad315db for a full test report.

@boegel boegel deleted the 20200821121912_new_pr_TensorFlow220 branch August 26, 2020 19:04
@boegel boegel mentioned this pull request Sep 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lexming lexming lexming approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @boegelbot @lexming