Skip to content

{lang}[GCCcore/9.3.0] moonjit v2.2.0#11163

Merged
lexming merged 2 commits intoeasybuilders:developfrom
furstj:20200826160028_new_pr_moonjit220
Aug 28, 2020
Merged

{lang}[GCCcore/9.3.0] moonjit v2.2.0#11163
lexming merged 2 commits intoeasybuilders:developfrom
furstj:20200826160028_new_pr_moonjit220

Conversation

@furstj
Copy link
Copy Markdown
Contributor

@furstj furstj commented Aug 26, 2020

(created using eb --new-pr)

@lexming lexming added the new label Aug 28, 2020
@lexming lexming added this to the next release (4.3.0) milestone Aug 28, 2020
@lexming
Copy link
Copy Markdown
Contributor

lexming commented Aug 28, 2020

Test report by @lexming
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node368.hydra.os - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/f97f876737af5eb64bfeb9c68c92cab7 for a full test report.

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Aug 28, 2020

Test report by @lexming
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node124.hydra.os - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) CPU E5-2680 v2 @ 2.80GHz, Python 2.7.5
See https://gist.github.com/12ed332f75cedc62e5fdd2aac050734f for a full test report.

lexming
lexming requested changes Aug 28, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build of moonjit works well. I just have a minor remark about the sanity checks, which can be improved. Please sea below

Comment thread easybuild/easyconfigs/m/moonjit/moonjit-2.2.0-GCCcore-9.3.0.eb Outdated
lexming
lexming approved these changes Aug 28, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Aug 28, 2020

Test report by @lexming
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node312.hydra.os - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/4bf9ad8b408efd0d4501b102a18234fd for a full test report.

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Aug 28, 2020

Going in, thanks @furstj !

@lexming lexming merged commit 7f868a5 into easybuilders:develop Aug 28, 2020
@lexming
Copy link
Copy Markdown
Contributor

lexming commented Aug 28, 2020

Test report by @lexming
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node124.hydra.os - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) CPU E5-2680 v2 @ 2.80GHz, Python 2.7.5
See https://gist.github.com/48e1df0425523c93837237e66740f7b6 for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lexming lexming lexming approved these changes

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

4.3.0

Development

Successfully merging this pull request may close these issues.

2 participants

@furstj @lexming