Skip to content

fix failing 'make check' for recent GMP easyconfigs when installing with 'eb --rpath'#11188

Merged
smoors merged 6 commits intoeasybuilders:developfrom
boegel:20200831183527_new_pr_GMP432
Sep 2, 2020
Merged

fix failing 'make check' for recent GMP easyconfigs when installing with 'eb --rpath'#11188
smoors merged 6 commits intoeasybuilders:developfrom
boegel:20200831183527_new_pr_GMP432

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Aug 31, 2020

(created using eb --new-pr)

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Aug 31, 2020

Test report by @boegel
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in this PR)
node3170.skitty.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/471c21d6d192a70c739d0038424b9ccc for a full test report.

@boegel boegel added this to the next release (4.3.0) milestone Aug 31, 2020
@boegel boegel added bug fix EESSI Related to EESSI project labels Aug 31, 2020
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Sep 1, 2020 •
edited
Loading

@boegelbot please test @ generoso
EB_ARGS=" GMP-6.1.2-GCCcore-7.3.0.eb GMP-6.1.2-GCCcore-8.2.0.eb GMP-6.1.2-GCCcore-8.3.0.eb GMP-6.2.0-GCCcore-9.3.0.eb --rpath -f --installpath /tmp/pr11188"

(older toolchains no longer work on CentOS 8)

@boegel boegel requested a review from smoors September 1, 2020 12:12
smoors
smoors requested changes Sep 1, 2020
View reviewed changes
Comment thread easybuild/easyconfigs/g/GMP/GMP-6.1.2-GCCcore-6.3.0.eb Outdated
@boegel boegel changed the title fix failing 'make check' for recent GMP easyconfigs when installing with 'eb --rpath' [WIP] fix failing 'make check' for recent GMP easyconfigs when installing with 'eb --rpath' Sep 1, 2020
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Sep 1, 2020

Don't merge this yet please, needs more love...

@easybuilders easybuilders deleted a comment from boegelbot Sep 1, 2020
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 1, 2020

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=11188 EB_ARGS=" GMP-6.1.2-GCCcore-7.3.0.eb GMP-6.1.2-GCCcore-8.2.0.eb GMP-6.1.2-GCCcore-8.3.0.eb GMP-6.2.0-GCCcore-9.3.0.eb --rpath -f --installpath /tmp/pr11188" /apps/slurm/default/bin/sbatch --job-name test_PR_11188 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5213

Test results coming soon (I hope)...

Details

- notification for comment with ID 684800287 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 1, 2020

Test report by @boegelbot
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in this PR)
generoso-x-4 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/91672276a832703495648f61ef796f8e for a full test report.

@boegel boegel changed the title [WIP] fix failing 'make check' for recent GMP easyconfigs when installing with 'eb --rpath' fix failing 'make check' for recent GMP easyconfigs when installing with 'eb --rpath' Sep 1, 2020
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Sep 1, 2020

Test report by @boegel
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in this PR)
node3108.skitty.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/2e7221dfe2b91825f1c5ce350cb24578 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Sep 2, 2020

@smoors Should be good to go now!

smoors
smoors approved these changes Sep 2, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Sep 2, 2020

Going in, thanks @boegel!

@smoors smoors merged commit adc3ed7 into easybuilders:develop Sep 2, 2020
@boegel boegel deleted the 20200831183527_new_pr_GMP432 branch September 2, 2020 12:50
@boegel boegel mentioned this pull request Sep 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smoors smoors smoors approved these changes

Assignees

No one assigned

Labels

bug fix EESSI Related to EESSI project

Projects

None yet

Milestone

4.3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @boegelbot @smoors