Skip to content

pkg-config is required as a build dependency for libglvnd#11189

Merged
smoors merged 3 commits intoeasybuilders:developfrom
terjekv:20200831230552_new_pr_libglvnd120
Sep 1, 2020
Merged

pkg-config is required as a build dependency for libglvnd#11189
smoors merged 3 commits intoeasybuilders:developfrom
terjekv:20200831230552_new_pr_libglvnd120

Conversation

@terjekv
Copy link
Copy Markdown
Collaborator

@terjekv terjekv commented Aug 31, 2020

(created using eb --new-pr)

@terjekv terjekv changed the title pkg-config is required as a build dependency. pkg-config is required as a build dependency for libglvnd Aug 31, 2020
@terjekv terjekv requested a review from bartoldeman September 1, 2020 07:01
@easybuilders easybuilders deleted a comment from boegelbot Sep 1, 2020
@easybuilders easybuilders deleted a comment from boegelbot Sep 1, 2020
@smoors
Copy link
Copy Markdown
Contributor

smoors commented Sep 1, 2020

EB_ARGS="--force --debug" @boegelbot please test @ generoso

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Sep 1, 2020

Test report by @smoors
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
node254.hydra.os - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) CPU E5-2683 v4 @ 2.10GHz (broadwell), Python 2.7.5
See https://gist.github.com/00c30553fce0d80495e1d553aa826a24 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 1, 2020

@smoors: Request for testing this PR well received on generoso

PR test command 'EB_PR=11189 EB_ARGS="--force --debugplease" /apps/slurm/default/bin/sbatch --job-name test_PR_11189 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5187

Test results coming soon (I hope)...

Details

- notification for comment with ID 684584843 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Sep 1, 2020

@boegelbot please test @ generoso EB_ARGS="--force --debug"

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 1, 2020

@smoors: Request for testing this PR well received on generoso

PR test command 'EB_PR=11189 EB_ARGS="--force --debug" /apps/slurm/default/bin/sbatch --job-name test_PR_11189 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5188

Test results coming soon (I hope)...

Details

- notification for comment with ID 684629336 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 1, 2020

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
generoso-x-3 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/f8109306df5a1350c629de1209809c7c for a full test report.

@boegel boegel added the bug fix label Sep 1, 2020
@boegel boegel added this to the next release (4.3.0) milestone Sep 1, 2020
@boegel boegel removed the request for review from bartoldeman September 1, 2020 12:12
@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 1, 2020

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
node3108.skitty.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/96bd77e61a3c6cb20a8184bee16a4204 for a full test report.

@smoors smoors mentioned this pull request Sep 1, 2020
Merged
smoors
smoors approved these changes Sep 1, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Sep 1, 2020

Going in, thanks @terjekv!

@smoors smoors merged commit f356729 into easybuilders:develop Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smoors smoors smoors approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.3.0

Development

Successfully merging this pull request may close these issues.

4 participants

@terjekv @smoors @boegelbot @boegel