Skip to content

fix build problems with make 4.2.1 on RHEL8#11282

Merged
boegel merged 2 commits intoeasybuilders:developfrom
hajgato:make_el8
Sep 17, 2020
Merged

fix build problems with make 4.2.1 on RHEL8#11282
boegel merged 2 commits intoeasybuilders:developfrom
hajgato:make_el8

Conversation

@hajgato
Copy link
Copy Markdown
Collaborator

@hajgato hajgato commented Sep 16, 2020 •
edited
Loading

edit (by @boegel): this fixes the following installation failure:

glob/libglob.a(glob.o):glob.c:function glob_in_dir: error: undefined reference to '__alloca'

One solution can be this http://gnu-make.2324884.n4.nabble.com/undefined-reference-to-alloca-td18308.html

@easybuilders easybuilders deleted a comment from boegelbot Sep 17, 2020
@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 17, 2020

@boegelbot please test @ generoso

@boegel boegel added this to the next release (4.3.1) milestone Sep 17, 2020
@boegel boegel added the bug fix label Sep 17, 2020
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 17, 2020

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=11282 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_11282 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7820

Test results coming soon (I hope)...

Details

- notification for comment with ID 694080474 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 17, 2020

Test report by @boegelbot
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in this PR)
generoso-x-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/176ab1bddd64840a6e043402bed91f0c for a full test report.

boegel
boegel approved these changes Sep 17, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hajgato Maybe include a reference (in a comment in this PR) to the link that helped you pinpoint the cause of this problem?

@boegel boegel changed the title Fix make 4.2.1 on RHEL 8 fix build problems with make 4.2.1 on RHEL8 Sep 17, 2020
@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 17, 2020

Test report by @boegel
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in this PR)
node2412.golett.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz (haswell), Python 2.7.5
See https://gist.github.com/1f57f5ab205f0619347de900c9293515 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 17, 2020

Going in, thanks @hajgato!

@boegel boegel merged commit bf99b3c into easybuilders:develop Sep 17, 2020
@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 17, 2020

Test report by @boegel
SUCCESS
Build succeeded for 20 out of 20 (4 easyconfigs in this PR)
node3404.kirlia.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6240 CPU @ 2.60GHz (cascadelake), Python 2.7.5
See https://gist.github.com/a8e8f3bad8f10756714fa4d37720aadd for a full test report.

@hajgato
Copy link
Copy Markdown
Collaborator Author

hajgato commented Sep 25, 2020

this still core dumps in real life situation.

@hajgato hajgato mentioned this pull request Sep 25, 2020
Closed
@hajgato
Copy link
Copy Markdown
Collaborator Author

hajgato commented Sep 25, 2020

the real solution is here: #11371

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.3.1

Development

Successfully merging this pull request may close these issues.

3 participants

@hajgato @boegel @boegelbot