Skip to content

Remove GLog and GFlags from PyTorch 1.4.0#11322

Merged
boegel merged 1 commit intoeasybuilders:developfrom
Flamefire:pytorch1.4-remove-glog-gflags
Sep 23, 2020
Merged

Remove GLog and GFlags from PyTorch 1.4.0#11322
boegel merged 1 commit intoeasybuilders:developfrom
Flamefire:pytorch1.4-remove-glog-gflags

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

@Flamefire Flamefire commented Sep 22, 2020

As discussed in Slack and confirmed in pytorch/pytorch#44948 using those 2 is not officially tested and known to cause problems at least on POWER architectures

Hence the removal

@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Sep 22, 2020

Test report by @Flamefire
FAILED
Build succeeded for 1 out of 2 (2 easyconfigs in this PR)
taurusml17 - Linux RHEL 7.6, POWER, 8335-GTX, Python 2.7.5
See https://gist.github.com/cc479cd44db9416b8832c041685e239b for a full test report.

@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Sep 22, 2020

Test report by @Flamefire
SUCCESS
Build succeeded for 3 out of 3 (2 easyconfigs in this PR)
taurusi5532.taurus.hrsk.tu-dresden.de - Linux RHEL 7.8, x86_64, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/6b03133c380c7f31b4b015c1403c5fbc for a full test report.

@boegel boegel added this to the next release (4.3.1) milestone Sep 23, 2020
boegel
boegel approved these changes Sep 23, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 23, 2020

@boegelbot please test @ generoso

@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Sep 23, 2020 •
edited
Loading

The failures on Power seems to be caused by OpenMP using code and go away with reducing OMP_NUM_THREADS but I already do that... Strange, so I guess still a bit flaky even with only 4 OMP threads

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 23, 2020

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=11322 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_11322 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7857

Test results coming soon (I hope)...

Details

- notification for comment with ID 697299579 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 23, 2020

@Flamefire failing test on POWER?

@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Sep 23, 2020

Test report by @Flamefire
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
taurusml21 - Linux RHEL 7.6, POWER, 8335-GTX, Python 2.7.5
See https://gist.github.com/994335e389ecd40f77bacc15f9bc10f5 for a full test report.

@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Sep 23, 2020

🤷 Seems to work

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 23, 2020

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
generoso-x-2 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/ec1808dba5d19e11042a9a8b34f59fdc for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 23, 2020

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node2561.golett.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz (haswell), Python 2.7.5
See https://gist.github.com/31c91f40257783cfd7846f84a12239ef for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 23, 2020

Going in, thanks @Flamefire!

@boegel boegel merged commit fbed872 into easybuilders:develop Sep 23, 2020
@Flamefire Flamefire deleted the pytorch1.4-remove-glog-gflags branch September 23, 2020 16:18
@lexming
Copy link
Copy Markdown
Contributor

lexming commented Sep 23, 2020

Test report by @lexming
FAILED
Build succeeded for 1 out of 2 (2 easyconfigs in this PR)
node157.hydra.os - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) CPU E5-2680 v2 @ 2.80GHz, Python 2.7.5
See https://gist.github.com/b9948bc5cd09fea992185c79272343b2 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 23, 2020

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node3404.kirlia.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6240 CPU @ 2.60GHz (cascadelake), Python 2.7.5
See https://gist.github.com/1107eccdbb2d86e9b2f647a8f6eace59 for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix change

Projects

None yet

Milestone

4.3.1

Development

Successfully merging this pull request may close these issues.

4 participants

@Flamefire @boegel @boegelbot @lexming