Skip to content

add patch for LAME configure script to make it check for correct ncurses symbol#11388

Merged
smoors merged 2 commits intoeasybuilders:developfrom
boegel:20200926171419_new_pr_LAME3100
Oct 1, 2020
Merged

add patch for LAME configure script to make it check for correct ncurses symbol#11388
smoors merged 2 commits intoeasybuilders:developfrom
boegel:20200926171419_new_pr_LAME3100

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Sep 26, 2020

(created using eb --new-pr)

@boegel boegel added bug fix EESSI Related to EESSI project labels Sep 26, 2020
@boegel boegel added this to the next release (4.3.1) milestone Sep 26, 2020
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Sep 26, 2020

@boegelbot please test @ generoso
EB_ARGS="LAME-3.100-GCCcore-9.3.0.eb LAME-3.100-GCCcore-8.3.0.eb LAME-3.100-GCCcore-8.2.0.eb LAME-3.100-GCCcore-7.3.0.eb"

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Sep 26, 2020

Test report by @boegel
SUCCESS
Build succeeded for 8 out of 8 (8 easyconfigs in this PR)
node2633.swalot.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 2.7.5
See https://gist.github.com/ac9fd4af13c0a13bc66296dc55e9226d for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 26, 2020

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=11388 EB_ARGS="LAME-3.100-GCCcore-9.3.0.eb LAME-3.100-GCCcore-8.3.0.eb LAME-3.100-GCCcore-8.2.0.eb LAME-3.100-GCCcore-7.3.0.eb" /apps/slurm/default/bin/sbatch --job-name test_PR_11388 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7975

Test results coming soon (I hope)...

Details

- notification for comment with ID 699513319 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 26, 2020

Test report by @boegelbot
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in this PR)
generoso-x-5 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/6ca39a6eb977d5285836bd49b884c24e for a full test report.

@boegel boegel mentioned this pull request Sep 30, 2020
Closed
@smoors
Copy link
Copy Markdown
Contributor

smoors commented Oct 1, 2020

Test report by @smoors
SUCCESS
Build succeeded for 8 out of 8 (8 easyconfigs in this PR)
node375.hydra.os - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz (skylake_avx512), Python 2.7.5
See https://gist.github.com/e4f4094d837c03274cef6c9ddfa6a3fb for a full test report.

smoors
smoors approved these changes Oct 1, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Oct 1, 2020

Going in, thanks @boegel!

@smoors smoors merged commit 799dd5f into easybuilders:develop Oct 1, 2020
@boegel boegel deleted the 20200926171419_new_pr_LAME3100 branch October 2, 2020 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smoors smoors smoors approved these changes

Assignees

No one assigned

Labels

bug fix EESSI Related to EESSI project

Projects

None yet

Milestone

4.3.1

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @boegelbot @smoors