Skip to content

add SPRNG for ictce-5.3 toolchains and amend HPCBIOS_Math#1141

Merged
boegel merged 2 commits intoeasybuilders:developfrom
fgeorgatos:contrib_HPCBIOS_Math_update_and_some_SPRNG2
Oct 26, 2014
Merged

add SPRNG for ictce-5.3 toolchains and amend HPCBIOS_Math#1141
boegel merged 2 commits intoeasybuilders:developfrom
fgeorgatos:contrib_HPCBIOS_Math_update_and_some_SPRNG2

Conversation

@fgeorgatos
Copy link
Copy Markdown
Contributor

Signed-off-by: Fotis Georgatos [email protected]

@hpcugentbot
Copy link
Copy Markdown

Test FAILed.

@fgeorgatos
Copy link
Copy Markdown
Contributor Author

Just for the record, the following URL revealed a number of other potential patches for SPRNG:
https://stat.ethz.ch/pipermail/r-sig-hpc/2010-January/000512.html
I will not be reacting on it now, but keep on eye on it because somebody one day will meet the need...

@hpcugentbot
Copy link
Copy Markdown

Test PASSed.

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 13, 2014

@fgeorgatos: those patches don't seem to help with the segfaults with checksprng or timesprng, and don't seem to be needed to make the build work either?

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 13, 2014

Test report by @boegel
FAILED
Build succeeded for 2 out of 5
Linux SL 6.5, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/86e4512bf4a885680b1d for a full test report.

@fgeorgatos
Copy link
Copy Markdown
Contributor Author

Test report by @fgeorgatos
FAILED
Build succeeded for 2 out of 5
Linux debian 6.0.9, Intel(R) Xeon(R) CPU X5670 @ 2.93GHz, Python 2.6.6
See https://gist.github.com/c0d032f1da1e112d89a3 for a full test report.

@fgeorgatos
Copy link
Copy Markdown
Contributor Author

Test report by @fgeorgatos
SUCCESS
Build succeeded for 5 out of 5
Linux debian 6.0.9, Intel(R) Xeon(R) CPU X5670 @ 2.93GHz, Python 2.6.6
See https://gist.github.com/d9d3ca569bf49c3bf5be for a full test report.

@fgeorgatos
Copy link
Copy Markdown
Contributor Author

Hi Ken,

the only reason our previous tries gave an error is a trivial issue, of a non-visible patch file; fixable with:
cp SPRNG-2.0_fix-metropolis-test.patch .local/easybuild/sources/s/SPRNG/

Now, status is SUCCESS on my side, just attempt something similar on your side.

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 13, 2014

@fgeorgatos: now #1138 is merged in, syncing this branch with develop is sufficient as well (EB looks for patch files next to the easyconfig file location as well)

@fgeorgatos
Copy link
Copy Markdown
Contributor Author

@boegel: fully agreed with your proposition;

However, the branch was synced already and, AFAI understand, it is the fact that patchfiles searching occurs in different paths, during --from-pr usage that triggered the issue. It could be a bug or, it could be a feature, depending how you look at it?!

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 14, 2014

Test report by @boegel
FAILED
Build succeeded for 2 out of 5
Linux SL 6.5, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/b48947796a9e34aaecea for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 14, 2014

@fgeorgatos: I'm running into the same issue now, but this must be a bug in the --from-pr functionality... EB is looking for the patch file in the right location, but not finding it there, which is definitely a bug. I'll look into it.

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 26, 2014

OK, I checked this, and the issue is that the patch is not available next to the downloaded easyconfigs (since it's not being touched in this PR), causing it not to be found by EasyBuild, since it only looks in certain locations (source path, next to easyconfig, robot path, etc.).

So, there's nothing wrong with this PR. If you would use --from-pr on top of the current develop version of the easyconfigs repo, then it will work too.

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 26, 2014

Test report by @boegel
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in this PR)
Linux SL 6.5, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/95c5c71c56a841a1a44c for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 26, 2014

Green light by Jenkins when using --from-pr on top of current develop branches, so good to go in. Thanks @fgeorgatos!

boegel added a commit that referenced this pull request Oct 26, 2014
…and_some_SPRNG2

add SPRNG for ictce-5.3 toolchains and amend HPCBIOS_Math
@boegel boegel merged commit b498f2e into easybuilders:develop Oct 26, 2014
@fgeorgatos fgeorgatos deleted the contrib_HPCBIOS_Math_update_and_some_SPRNG2 branch October 26, 2014 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants