Skip to content

Add ncurses runtime dependency to Clang 10.x easyconfigs using GCCcore/9.3.0#11419

Merged
smoors merged 1 commit intoeasybuilders:developfrom
Flamefire:20201002101428_new_pr_Clang1000
Oct 2, 2020
Merged

Add ncurses runtime dependency to Clang 10.x easyconfigs using GCCcore/9.3.0#11419
smoors merged 1 commit intoeasybuilders:developfrom
Flamefire:20201002101428_new_pr_Clang1000

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

@Flamefire Flamefire commented Oct 2, 2020

(created using eb --new-pr)

@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Oct 2, 2020

ccing @smoors

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Oct 2, 2020

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 2, 2020

@smoors: Request for testing this PR well received on generoso

PR test command 'EB_PR=11419 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_11419 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8002

Test results coming soon (I hope)...

Details

- notification for comment with ID 702673783 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 2, 2020

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
generoso-x-4 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/11bbc781cc30ad67fbe086bf0b97a484 for a full test report.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Oct 2, 2020

Test report by @smoors
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node358.hydra.os - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz (skylake_avx512), Python 2.7.5
See https://gist.github.com/27e65b9f57c0e6017e7f8c2ed02cec93 for a full test report.

smoors
smoors approved these changes Oct 2, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors smoors added this to the next release (4.3.1) milestone Oct 2, 2020
@smoors
Copy link
Copy Markdown
Contributor

smoors commented Oct 2, 2020

Going in, thanks @Flamefire!

@smoors smoors merged commit a447f26 into easybuilders:develop Oct 2, 2020
@boegel boegel changed the title Add ncurses runtime dependency to Clang Add ncurses runtime dependency to Clang 10.x easyconfigs using GCCcore/9.3.0 Oct 3, 2020
@Flamefire Flamefire deleted the 20201002101428_new_pr_Clang1000 branch October 5, 2020 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smoors smoors smoors approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

4.3.1

Development

Successfully merging this pull request may close these issues.

3 participants

@Flamefire @smoors @boegelbot