Skip to content

add patches for OpenBLAS easyconfigs using GCC/8.3.0 toolchain to fix miscomputation on POWER and performance issues#11444

Merged
boegel merged 3 commits intoeasybuilders:developfrom
Flamefire:20201007112213_new_pr_OpenBLAS036
Oct 10, 2020
Merged

add patches for OpenBLAS easyconfigs using GCC/8.3.0 toolchain to fix miscomputation on POWER and performance issues#11444
boegel merged 3 commits intoeasybuilders:developfrom
Flamefire:20201007112213_new_pr_OpenBLAS036

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

@Flamefire Flamefire commented Oct 7, 2020

(created using eb --new-pr)

@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Oct 7, 2020

Test report by @Flamefire
SUCCESS
Build succeeded for 3 out of 3 (2 easyconfigs in this PR)
taurusml6 - Linux RHEL 7.6, POWER, 8335-GTX, Python 2.7.5
See https://gist.github.com/e6c713e98ebb2372bba7659b60fd414e for a full test report.

@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Oct 7, 2020

Test report by @Flamefire
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
taurusml6 - Linux RHEL 7.6, POWER, 8335-GTX, Python 2.7.5
See https://gist.github.com/159bb5f79211ce68ceca79c164b7f4e7 for a full test report.

@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Oct 7, 2020

Test report by @Flamefire
SUCCESS
Build succeeded for 3 out of 3 (2 easyconfigs in this PR)
taurusi5423.taurus.hrsk.tu-dresden.de - Linux RHEL 7.8, x86_64, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/3cd3d1d6b300d0deef239ce9d7359479 for a full test report.

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Oct 9, 2020

Test report by @verdurin
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
nuc.lan - Linux Fedora 32, x86_64, Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz, Python 3.8.5
See https://gist.github.com/fbd688573c191e4eaf5944e24fde75db for a full test report.

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Oct 9, 2020

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 9, 2020

@verdurin: Request for testing this PR well received on generoso

PR test command 'EB_PR=11444 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_11444 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8041

Test results coming soon (I hope)...

Details

- notification for comment with ID 706139339 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 9, 2020

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (2 easyconfigs in this PR)
generoso-x-2 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/30a8f12a0eaab2be11a58bab94d99a56 for a full test report.

@verdurin verdurin added this to the next release (4.3.1) milestone Oct 9, 2020
@verdurin
Copy link
Copy Markdown
Member

verdurin commented Oct 9, 2020

Would like to see more tests for this, ideally. @zao ?

@zao
Copy link
Copy Markdown
Contributor

zao commented Oct 9, 2020

Test report by @zao
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
freja - Linux Ubuntu 20.04, x86_64, Intel(R) Core(TM) i7-8700K CPU @ 3.70GHz, Python 3.8.5
See https://gist.github.com/d4349d0eadc6cfc553ab31631fb36ec1 for a full test report.

@boegel boegel changed the title [OpenBLAS] Add patches fixing miscomputation and performance issues add patches for OpenBLAS easyconfigs using GCC/8.3.0 toolchain to fix miscomputation and performance issues Oct 10, 2020
@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 10, 2020

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node3404.kirlia.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6240 CPU @ 2.60GHz (cascadelake), Python 2.7.5
See https://gist.github.com/c3f19414d4c7ffe1570e3dd2f98a2d0d for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 10, 2020

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node2616.swalot.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 2.7.5
See https://gist.github.com/3a304bf1e31d9caab65dac4d719688e6 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 10, 2020

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (2 easyconfigs in this PR)
node3100.skitty.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/271f1b6b16c74a3c3c30fb830a73abad for a full test report.

boegel
boegel approved these changes Oct 10, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 10, 2020

Going in, thanks @Flamefire!

@boegel boegel merged commit 41b7169 into easybuilders:develop Oct 10, 2020
@Flamefire Flamefire deleted the 20201007112213_new_pr_OpenBLAS036 branch October 10, 2020 14:39
@zao
Copy link
Copy Markdown
Contributor

zao commented Oct 10, 2020

Test report by @zao
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
dagur - Linux Ubuntu 20.04, x86_64, AMD Ryzen 9 3900X 12-Core Processor, Python 3.8.2
See https://gist.github.com/cc9c29aafaffdbdcb713a7896be1adce for a full test report.

@boegel boegel changed the title add patches for OpenBLAS easyconfigs using GCC/8.3.0 toolchain to fix miscomputation and performance issues add patches for OpenBLAS easyconfigs using GCC/8.3.0 toolchain to fix miscomputation on POWER and performance issues Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.3.1

Development

Successfully merging this pull request may close these issues.

5 participants

@Flamefire @verdurin @boegelbot @zao @boegel