Skip to content

Fix source for SQLite 3.31.1#11483

Merged
boegel merged 4 commits intoeasybuilders:developfrom
Micket:20201013175515_new_pr_SQLite3311
Oct 13, 2020
Merged

Fix source for SQLite 3.31.1#11483
boegel merged 4 commits intoeasybuilders:developfrom
Micket:20201013175515_new_pr_SQLite3311

Conversation

@Micket
Copy link
Copy Markdown
Contributor

@Micket Micket commented Oct 13, 2020

(created using eb --new-pr)

@Micket Micket changed the title Fix source for SQLie 3.31.1 Fix source for SQLite 3.31.1 Oct 13, 2020
@Micket Micket added the bug fix label Oct 13, 2020
@Micket Micket added this to the next release (4.3.1) milestone Oct 13, 2020
@Micket Micket requested a review from boegel October 13, 2020 16:12
@Micket
Copy link
Copy Markdown
Contributor Author

Micket commented Oct 13, 2020

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

@Micket: I noticed your comment, but I only dance when @bartoldeman or @boegel or @casparvl or @migueldiascosta or @smoors or @verdurin tells me (for now), I'm sorry...

Details

- notification for comment with ID 707882791 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Oct 13, 2020

Test report by @lexming
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
node101.hydra.os - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) CPU E5-2680 v2 @ 2.80GHz, Python 2.7.5
See https://gist.github.com/e6aa010890e3d56d34faf8a829d436bc for a full test report.

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Oct 13, 2020

Test report by @lexming
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
node379.hydra.os - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/551ff5f432a42d58a98a40887d787901 for a full test report.

@Micket
Copy link
Copy Markdown
Contributor Author

Micket commented Oct 13, 2020

Seems like my filename pattern failed in this case.. in fact, i'm not sure what the filename ought to be

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Oct 13, 2020

@Micket this is the URL for v3.31.1: https://www.sqlite.org/2020/sqlite-autoconf-3310100.tar.gz
So it is more complicated than a simple join, each subversion uses 2 digits in the name of the tarball.

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Oct 13, 2020

@Micket something like this would do the version string conversion

'{:d}{:02d}{:02d}00'.format(*[int(v) for v in '%(version)s'.split('.')])

@Micket
Copy link
Copy Markdown
Contributor Author

Micket commented Oct 13, 2020

@lexming @boegel downvoted my suggested

local_filename_version = '{0}{1:>02}{2:>02}{3:>02}'.format(*(version.split('.')+ [0]))

(which would also handle the case of a sub-patch release they sometimes have for the last 2 digits)

So, hardcoded string + sanity check it is

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Oct 13, 2020

Test report by @lexming
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
node381.hydra.os - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/12e89637accb0ea41c32861ab72cccd0 for a full test report.

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Oct 13, 2020

Test report by @lexming
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
node101.hydra.os - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) CPU E5-2680 v2 @ 2.80GHz, Python 2.7.5
See https://gist.github.com/b539c7d48db821a1b29a6583e743b234 for a full test report.

@Micket
Copy link
Copy Markdown
Contributor Author

Micket commented Oct 13, 2020

Totally forgot that the checksum is (of course) wrong

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 13, 2020

@boegelbot please test @ generoso

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 13, 2020

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node2645.swalot.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 2.7.5
See https://gist.github.com/3328edfa50a7cf1d8eb9486d13fe9704 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=11483 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_11483 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8066

Test results coming soon (I hope)...

Details

- notification for comment with ID 707978780 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 13, 2020

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node3109.skitty.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/085da2e7b75cae8dc3c0b149e7ad87b9 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
generoso-x-3 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/e0b035c0b35b439b704945f9ba461fec for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 13, 2020

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3502.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7302P 16-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/9692a06d0096f457e149795a77780430 for a full test report.

Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit 573546b into easybuilders:develop Oct 13, 2020
@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 13, 2020

@Micket Do you think it's worth it to backport the sanity check command to older SQLite easyconfigs?

@Micket
Copy link
Copy Markdown
Contributor Author

Micket commented Oct 13, 2020

@boegel My vote is no, not worth it

@Micket Micket deleted the 20201013175515_new_pr_SQLite3311 branch April 21, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants