Skip to content

{perf}[gompi/2020a] Backported fixes for Score-P v6.0#11540

Merged
smoors merged 2 commits intoeasybuilders:developfrom
geimer:scorep6-backported_fixes
Oct 20, 2020
Merged

{perf}[gompi/2020a] Backported fixes for Score-P v6.0#11540
smoors merged 2 commits intoeasybuilders:developfrom
geimer:scorep6-backported_fixes

Conversation

@geimer
Copy link
Copy Markdown
Contributor

@geimer geimer commented Oct 19, 2020 •
edited
Loading

Amend #11123 to support the binutils 2.34 API in another source-code location (discovered recently; used when built for PGI/NVHPC compilers, for example) and add a patch to prevent PDT instrumentation of .cu files. The latter fixes a make installcheck failure when both PDT and CUDA are configured, but can also show up in real life.

@geimer geimer force-pushed the scorep6-backported_fixes branch from 4f2a99b to f4fdf37 Compare October 19, 2020 12:38
@geimer
Copy link
Copy Markdown
Contributor Author

geimer commented Oct 19, 2020

Test report by @geimer
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
zam540 - Linux debian 10.6, x86_64, Intel(R) Core(TM) i5-8265U CPU @ 1.60GHz, Python 2.7.16
See https://gist.github.com/cc0fca380e7a10e13e2dd9aac3792d10 for a full test report.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Oct 20, 2020

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 20, 2020

@smoors: Request for testing this PR well received on generoso

PR test command 'EB_PR=11540 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_11540 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8174

Test results coming soon (I hope)...

Details

- notification for comment with ID 712653110 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 20, 2020

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
generoso-x-2 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/14e3cbc01a472a7ff1d4e20510b83f06 for a full test report.

boegel
boegel approved these changes Oct 20, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel added the bug fix label Oct 20, 2020
@boegel boegel added this to the next release (4.3.1) milestone Oct 20, 2020
@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 20, 2020

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node3401.kirlia.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6240 CPU @ 2.60GHz (cascadelake), Python 2.7.5
See https://gist.github.com/9ca4f1724f9c203185cbac237cc47bae for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 20, 2020

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node2709.swalot.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 2.7.5
See https://gist.github.com/c19fbd69188ca9d5813756a2cd28d247 for a full test report.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Oct 20, 2020

Test report by @smoors
SUCCESS
Build succeeded for 16 out of 16 (2 easyconfigs in total)
node201.hydra.os - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) CPU E5-2680 v4 @ 2.40GHz (broadwell), Python 2.7.5
See https://gist.github.com/e60268b361f4787086d3cbf9446a8cfd for a full test report.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Oct 20, 2020

Going in, thanks @geimer!

@smoors smoors merged commit 9bd2bc7 into easybuilders:develop Oct 20, 2020
@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 20, 2020

Test report by @boegel
SUCCESS
Build succeeded for 9 out of 9 (2 easyconfigs in total)
node3118.skitty.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/44ae6f156f6d7f0cd5b88ffa7873ac85 for a full test report.

@geimer geimer deleted the scorep6-backported_fixes branch October 20, 2020 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.3.1

Development

Successfully merging this pull request may close these issues.

4 participants

@geimer @smoors @boegelbot @boegel