Skip to content

fix source_urls in Geant4 easyconfigs#11596

Merged
boegel merged 7 commits intoeasybuilders:developfrom
Micket:20201030175409_new_pr_Geant4106
Nov 2, 2020
Merged

fix source_urls in Geant4 easyconfigs#11596
boegel merged 7 commits intoeasybuilders:developfrom
Micket:20201030175409_new_pr_Geant4106

Conversation

@Micket
Copy link
Copy Markdown
Contributor

@Micket Micket commented Oct 30, 2020

(created using eb --new-pr)

@boegel boegel added the bug fix label Oct 31, 2020
@boegel boegel added this to the 4.3.2 milestone Oct 31, 2020
@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 31, 2020

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3412.kirlia.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6240 CPU @ 2.60GHz (cascadelake), Python 2.7.5
See https://gist.github.com/6cb88f0a81cc46addedce0fbdce44b3c for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 31, 2020

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node2498.golett.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz (haswell), Python 2.7.5
See https://gist.github.com/f242582cb030abfa8f7d41ae6ca3dc9d for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 31, 2020

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (1 easyconfigs in total)
node3104.skitty.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/5088125c37fae60757c87c7608ed1f45 for a full test report.

@boegel boegel mentioned this pull request Oct 31, 2020
Merged
boegel
boegel requested changes Oct 31, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Micket Let's also make this fix consistent across all Geant4 easyconfigs (download works fine with this source URL for even the ancient versions, I double checked that).

Done in Micket#2

Comment thread easybuild/easyconfigs/g/Geant4/Geant4-10.6-foss-2019b.eb Outdated
@Micket
Merge pull request #2 from boegel/20201030175409_new_pr_Geant4106
105b979 
consistently fix source_urls and homepage in Geant4 easyconfigs
@boegel boegel changed the title Fix source_urls for Geant4 10.6 fix source_urls in Geant4 easyconfigs Nov 2, 2020
@boegel boegel mentioned this pull request Nov 2, 2020
Merged
boegel
boegel requested changes Nov 2, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Micket tests are not happy about the http:// URLs in comments...

fixed in Micket#3

@Micket
Merge pull request #3 from boegel/20201030175409_new_pr_Geant4106
14dfbcb 
also use https URLs in comments in Geant4 easyconfigs
@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 2, 2020

Test report by @boegel
SUCCESS
Build succeeded for 12 out of 12 (12 easyconfigs in total)
node3105.skitty.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/73f80490be0fd4648633bb4de4248564 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 2, 2020

Test report by @boegel
SUCCESS
Build succeeded for 12 out of 12 (12 easyconfigs in total)
node2407.golett.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz (haswell), Python 2.7.5
See https://gist.github.com/66c00b679510d2d63660e0532e9161a8 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 2, 2020

Going in, thanks @Micket!

@boegel boegel merged commit 60229d8 into easybuilders:develop Nov 2, 2020
@Micket Micket deleted the 20201030175409_new_pr_Geant4106 branch April 21, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.3.2

Development

Successfully merging this pull request may close these issues.

2 participants

@Micket @boegel