Skip to content

Use correct OS deps in UCX 1.8.0 easyconfig#11702

Merged
lexming merged 1 commit intoeasybuilders:developfrom
Micket:20201113003604_new_pr_UCX180
Nov 13, 2020
Merged

Use correct OS deps in UCX 1.8.0 easyconfig#11702
lexming merged 1 commit intoeasybuilders:developfrom
Micket:20201113003604_new_pr_UCX180

Conversation

@Micket
Copy link
Copy Markdown
Contributor

@Micket Micket commented Nov 12, 2020 •
edited
Loading

(created using eb --new-pr)

this was surely just a typo and should be fixed a.s.a.p.

@Micket Micket added the bug fix label Nov 12, 2020
@Micket Micket added this to the 4.3.2 milestone Nov 12, 2020
@Micket Micket requested a review from boegel November 12, 2020 23:39
@Micket
Copy link
Copy Markdown
Contributor Author

Micket commented Nov 12, 2020

@boegelbot please test @ generoso

@Micket
Copy link
Copy Markdown
Contributor Author

Micket commented Nov 12, 2020

Test report by @Micket
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
alvis-c1 - Linux centos linux 7.8.2003, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/ef170158006028b4897535af3fddb6cf for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 12, 2020

@Micket: Request for testing this PR well received on generoso

PR test command 'EB_PR=11702 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_11702 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9764

Test results coming soon (I hope)...

Details

- notification for comment with ID 726409626 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 12, 2020

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
generoso-c1-s-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/3d3b9d4bf6f27d46c9777f26306c3ee9 for a full test report.

@lexming lexming mentioned this pull request Nov 13, 2020
Merged
@lexming
Copy link
Copy Markdown
Contributor

lexming commented Nov 13, 2020

Test report by @lexming
SUCCESS
Build succeeded for 3 out of 3 (1 easyconfigs in total)
node379.hydra.os - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/7806b8e59d53d1e943c0340276bb84a8 for a full test report.

lexming
lexming approved these changes Nov 13, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Nov 13, 2020

Going in, thanks @Micket !

@lexming lexming merged commit 5088a11 into easybuilders:develop Nov 13, 2020
@boegel boegel changed the title Use correct OS deps in UCX Use correct OS deps in UCX 1.8.0 easyconfig Nov 16, 2020
@Micket Micket deleted the 20201113003604_new_pr_UCX180 branch April 21, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lexming lexming lexming approved these changes

@boegel boegel Awaiting requested review from boegel

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.3.2

Development

Successfully merging this pull request may close these issues.

3 participants

@Micket @boegelbot @lexming