Skip to content

do not treat warnings as errors in Java v1.8_191-b26-OpenJDK (POWER)#11755

Merged
lexming merged 2 commits intoeasybuilders:developfrom
terjekv:20201124162942_new_pr_Java18_191
Nov 28, 2020
Merged

do not treat warnings as errors in Java v1.8_191-b26-OpenJDK (POWER)#11755
lexming merged 2 commits intoeasybuilders:developfrom
terjekv:20201124162942_new_pr_Java18_191

Conversation

@terjekv
Copy link
Copy Markdown
Collaborator

@terjekv terjekv commented Nov 24, 2020

(created using eb --new-pr)

readdir_r is deprecated. https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8179887

@terjekv terjekv changed the title Avoid failing due to readdir_r being deprecated. https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8179887 java/1.8_191-b26-OpenJDK fails due to readdir_r being deprecated. Nov 24, 2020
@terjekv
Copy link
Copy Markdown
Collaborator Author

terjekv commented Nov 24, 2020

@Flamefire Can you look at this and give it a whirl? It was required on RHEL8.3 on Power.

@Flamefire
Copy link
Copy Markdown
Contributor

Test report by @Flamefire
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
taurusml29 - Linux RHEL 7.6, POWER, 8335-GTX, Python 2.7.5
See https://gist.github.com/a21104bd78d74379aade734db89f51e6 for a full test report.

Comment thread easybuild/easyconfigs/j/Java/Java-1.8_191-b26-OpenJDK.eb Outdated
@lexming lexming changed the title java/1.8_191-b26-OpenJDK fails due to readdir_r being deprecated. do not treat warnings as errors in Java v1.8_191-b26-OpenJDK Nov 27, 2020
@lexming lexming added this to the 4.x milestone Nov 27, 2020
@terjekv terjekv requested a review from lexming November 27, 2020 21:56
@easybuilders easybuilders deleted a comment from boegelbot Nov 28, 2020
@boegel boegel changed the title do not treat warnings as errors in Java v1.8_191-b26-OpenJDK do not treat warnings as errors in Java v1.8_191-b26-OpenJDK (POWER) Nov 28, 2020
@boegel boegel modified the milestones: 4.x, 4.3.2 (next release) Nov 28, 2020
@boegel boegel dismissed lexming’s stale review November 28, 2020 10:26

long line fixed

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Nov 28, 2020

Test report by @lexming
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
node376.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/c26c9481253a318f3c42da7455c39ecd for a full test report.

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Nov 28, 2020

Test report by @lexming
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
node128.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2680 v2 @ 2.80GHz, Python 2.7.5
See https://gist.github.com/aab37d62dead5ba627ce737c90833be1 for a full test report.

@terjekv
Copy link
Copy Markdown
Collaborator Author

terjekv commented Nov 28, 2020

configure: error: Could not find all X11 headers (shape.h Xrender.h XTest.h Intrinsic.h). You might be able to fix this by running 'sudo yum install libXtst-devel libXt-devel libXrender-devel'.
configure exiting with result code 1

Why haven't we seen this before?

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Nov 28, 2020

@terjekv my test env is the best 😎

The missing header is actually XTest.h

checking for X11/extensions/shape.h... yes
checking for X11/extensions/Xrender.h... yes
checking for X11/extensions/XTest.h... no
configure: error: Could not find all X11 headers (shape.h Xrender.h XTest.h Intrinsic.h). You might be able to fix this     by running 'sudo yum install libXtst-devel libXt-devel libXrender-devel'.

@terjekv
Copy link
Copy Markdown
Collaborator Author

terjekv commented Nov 28, 2020

I thought that the OSDEP ('libXtst-devel', 'libxtst-dev'), was supposed to fix that? Hm.

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Nov 28, 2020

I do not have libXtst-devel installed and EB failed to tell me that.

@terjekv
Copy link
Copy Markdown
Collaborator Author

terjekv commented Nov 28, 2020

Okay, that's bad.

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Nov 28, 2020

@terjekv I found the issue, I always build with --force and that build option disables the validation of OS dependencies
@boegel is there another option allowing to ignore installed software but still check for OS deps?

@terjekv
Copy link
Copy Markdown
Collaborator Author

terjekv commented Nov 28, 2020

--rebuild?

@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 28, 2020

@lexming This Java easyconfig is only relevant for POWER, no? See Java-1.8.eb.

@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 28, 2020

--rebuild?

Indeed, --force is equivalent with --rebuild --ignore-osdeps

@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 28, 2020

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
easybuild1.novalocal - Linux centos linux 8.2.2004, POWER, IBM pSeries (emulated by qemu) (power8le), Python 3.6.8
See https://gist.github.com/fd81c1be3007055c412fbab863a9789f for a full test report.

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Nov 28, 2020

@boegel I'm so bad! how did I not think about --rebuild 😄
Regarding the architecture, this is used for POWER just because the lack of support in Oracle Java, but OpenJDK still works in x86 systems as well.

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Nov 28, 2020

Test report by @lexming
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
login4.phoenix.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2680 v2 @ 2.80GHz, Python 2.7.5
See https://gist.github.com/e5b61f16fca153583661f37833dbde2a for a full test report.

Copy link
Copy Markdown
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Nov 28, 2020

Going in, thanks @terjekv !

@lexming lexming merged commit 2e68a4d into easybuilders:develop Nov 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants