Skip to content

{tools}[system/system] code-server v3.7.3#11778

Merged
Micket merged 5 commits intoeasybuilders:developfrom
ocaisa:20201127160907_new_pr_code-server373
Dec 8, 2020
Merged

{tools}[system/system] code-server v3.7.3#11778
Micket merged 5 commits intoeasybuilders:developfrom
ocaisa:20201127160907_new_pr_code-server373

Conversation

@ocaisa
Copy link
Copy Markdown
Member

@ocaisa ocaisa commented Nov 27, 2020 •
edited
Loading

(created using eb --new-pr)

Requires easybuilders/easybuild-easyblocks#2255

@ocaisa ocaisa added the new label Nov 27, 2020
@ocaisa
Copy link
Copy Markdown
Member Author

ocaisa commented Nov 27, 2020

Test report by @ocaisa
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2255
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
alanc-VirtualBox - Linux Ubuntu 20.04, x86_64, Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz (sandybridge), Python 3.8.5
See https://gist.github.com/86b7f04616cc27c1b42f313a40742ad0 for a full test report.

@ocaisa
Copy link
Copy Markdown
Member Author

ocaisa commented Nov 27, 2020

Test report by @ocaisa
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2255
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
generoso - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz, Python 3.6.8
See https://gist.github.com/92a1a38d799ea6281d3d04f407605ad8 for a full test report.

@ocaisa
Copy link
Copy Markdown
Member Author

ocaisa commented Nov 27, 2020

Test report by @ocaisa
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2255
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
generoso - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz, Python 3.6.8
See https://gist.github.com/d1861a7829df81ab04d58eba1ab98693 for a full test report.

@easybuilders easybuilders deleted a comment from boegelbot Nov 27, 2020
boegel
boegel previously requested changes Dec 1, 2020
View reviewed changes
Comment thread easybuild/easyconfigs/c/code-server/code-server-3.7.3.eb Outdated
@boegel boegel added this to the 4.x milestone Dec 1, 2020
@boegel boegel mentioned this pull request Dec 1, 2020
Merged
@ocaisa
Copy link
Copy Markdown
Member Author

ocaisa commented Dec 1, 2020

Test report by @ocaisa
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2255
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
generoso - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz, Python 3.6.8
See https://gist.github.com/55f5eba16f88e0b469f87714330a3788 for a full test report.

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Dec 7, 2020

@boegelbot please test @ generoso EB_ARGS="--include-easyblocks-from-pr 2255"

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 7, 2020

@Micket: Request for testing this PR well received on generoso

PR test command 'EB_PR=11778 EB_ARGS="--include-easyblocks-from-pr 2255" /apps/slurm/default/bin/sbatch --job-name test_PR_11778 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12243

Test results coming soon (I hope)...

Details

- notification for comment with ID 740091661 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 7, 2020

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2255
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
generoso-c1-s-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/fbaad7f35a60aa24a25f94f622e3244b for a full test report.

@Micket Micket closed this Dec 7, 2020
@Micket Micket reopened this Dec 7, 2020
@ocaisa ocaisa closed this Dec 8, 2020
@ocaisa ocaisa reopened this Dec 8, 2020
@easybuilders easybuilders deleted a comment from boegelbot Dec 8, 2020
@easybuilders easybuilders deleted a comment from boegelbot Dec 8, 2020
@easybuilders easybuilders deleted a comment from boegelbot Dec 8, 2020
@Micket
Copy link
Copy Markdown
Contributor

Micket commented Dec 8, 2020

@boegelbot please test @ generoso EB_ARGS="--include-easyblocks-from-pr 2255"

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 8, 2020

@Micket: Request for testing this PR well received on generoso

PR test command 'EB_PR=11778 EB_ARGS="--include-easyblocks-from-pr 2255" /apps/slurm/default/bin/sbatch --job-name test_PR_11778 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12247

Test results coming soon (I hope)...

Details

- notification for comment with ID 740523908 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 8, 2020

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2255
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
generoso-c1-s-2 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/1de9d1e1561335decc0f118dfc29e1b2 for a full test report.

Micket
Micket approved these changes Dec 8, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket Micket dismissed boegel’s stale review December 8, 2020 10:17

looks fixed to me

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Dec 8, 2020

Going in, thanks @ocaisa!

@Micket Micket merged commit 8b640ff into easybuilders:develop Dec 8, 2020
@ocaisa ocaisa deleted the 20201127160907_new_pr_code-server373 branch December 8, 2020 14:25
@boegel boegel modified the milestones: 4.x, 4.3.2 (next release) Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Micket Micket Micket approved these changes

@boegel boegel boegel left review comments

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

4.3.2

Development

Successfully merging this pull request may close these issues.

4 participants

@ocaisa @Micket @boegelbot @boegel