Skip to content

fix compilation of TensorFlow 2.3.1 with CUDA and glibc 2.26 on POWER#11859

Merged
Micket merged 1 commit intoeasybuilders:developfrom
Flamefire:20201211102432_new_pr_TensorFlow231
Dec 22, 2020
Merged

fix compilation of TensorFlow 2.3.1 with CUDA and glibc 2.26 on POWER#11859
Micket merged 1 commit intoeasybuilders:developfrom
Flamefire:20201211102432_new_pr_TensorFlow231

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

@Flamefire Flamefire commented Dec 11, 2020 •
edited by boegel
Loading

(created using eb --new-pr)

fixes easybuilders/easybuild-easyblocks#2251

@Flamefire Flamefire mentioned this pull request Dec 11, 2020
Closed
@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Dec 11, 2020

Test report by @Flamefire
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
taurusml7 - Linux RHEL 7.6, POWER, 8335-GTX, Python 2.7.5
See https://gist.github.com/992ebfc89f2ce2e0f96a39eb162dc3b0 for a full test report.

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Dec 11, 2020

Test report by @branfosj
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0306u19a - Linux RHEL 8.2, POWER, 8335-GTX (power9le), Python 3.6.8
See https://gist.github.com/b538bf6c5ea3d830582ea1177232ccc4 for a full test report.

@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Dec 11, 2020

Test report by @Flamefire
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
taurusa5 - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) CPU E5-2603 v4 @ 1.70GHz, Python 2.7.5
See https://gist.github.com/102788f2536ee753b3cb431e31028fa3 for a full test report.

@terjekv
Copy link
Copy Markdown
Collaborator

terjekv commented Dec 12, 2020

Works for me, but I am currently unable to upload a test report from the RHEL8 Power system I have been building on.

@terjekv
Copy link
Copy Markdown
Collaborator

terjekv commented Dec 12, 2020

Oh, and shouldn't we also do this for https://github.com/easybuilders/easybuild-easyconfigs/blob/develop/easybuild/easyconfigs/t/TensorFlow/TensorFlow-2.2.0-fosscuda-2019b-Python-3.7.4.eb ?

@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Dec 12, 2020

Feel free if you need it. Just wanted to make this a PR to not let you test patch after patch ;)

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 12, 2020

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 12, 2020

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=11859 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_11859 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12282

Test results coming soon (I hope)...

Details

- notification for comment with ID 743913332 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 13, 2020

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
generoso-c1-s-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/d0149838c73e6c9e257deec88d6659d4 for a full test report.

branfosj
branfosj approved these changes Dec 13, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@branfosj branfosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket Micket added the bug fix label Dec 17, 2020
@Micket Micket added this to the next release (4.3.3?) milestone Dec 17, 2020
@branfosj branfosj mentioned this pull request Dec 21, 2020
Closed
Micket
Micket approved these changes Dec 22, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Dec 22, 2020

Going in, thanks @Flamefire!

@Micket Micket merged commit 297ecfb into easybuilders:develop Dec 22, 2020
@Flamefire Flamefire deleted the 20201211102432_new_pr_TensorFlow231 branch December 22, 2020 13:44
@Micket
Copy link
Copy Markdown
Contributor

Micket commented Dec 22, 2020

Test report by @Micket
FAILED
Build succeeded for 29 out of 33 (1 easyconfigs in this PR)
vera-c1 - Linux centos linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/331006092043c590b5a25c27a97b6970 for a full test report.

@boegel boegel changed the title Fix TF 2.3.1 compilation with GLIBC 2.26 on POWER fix compilation of TensorFlow 2.3.1 with glibc 2.26 on POWER Dec 22, 2020
@boegel boegel changed the title fix compilation of TensorFlow 2.3.1 with glibc 2.26 on POWER fix compilation of TensorFlow 2.3.1 with CUDA and glibc 2.26 on POWER Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@branfosj branfosj branfosj approved these changes

@Micket Micket Micket approved these changes

+1 more reviewer

@terjekv terjekv terjekv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.3.3

Development

Successfully merging this pull request may close these issues.

Building TensorFlow-2.[23].*-fosscuda-2019b-Python-3.7.4.eb on Power fails due to lack of __ieee128.

6 participants

@Flamefire @branfosj @terjekv @boegel @boegelbot @Micket