Skip to content

fix toolchain for pytest-xdist v2.1.0 w/ Python 3.8.6, should be GCCcore#11893

Merged
boegel merged 3 commits intoeasybuilders:developfrom
schiotz:20201216170835_new_pr_pytest-xdist210
Dec 16, 2020
Merged

fix toolchain for pytest-xdist v2.1.0 w/ Python 3.8.6, should be GCCcore#11893
boegel merged 3 commits intoeasybuilders:developfrom
schiotz:20201216170835_new_pr_pytest-xdist210

Conversation

@schiotz
Copy link
Copy Markdown
Contributor

@schiotz schiotz commented Dec 16, 2020

(created using eb --new-pr)

@schiotz schiotz changed the title {tools}[GCCcore/10.2.0] pytest-xdist v2.1.0 w/ Python 3.8.6 BUG FIX: pytest-xdist v2.1.0 w/ Python 3.8.6 Dec 16, 2020
@schiotz
Copy link
Copy Markdown
Contributor Author

schiotz commented Dec 16, 2020

This is a bug fix to PR #11883 which was merged earlier today by @boegel . I do not know why the system thinks it is a new file.

I made a serious error in PR #11883 : The file name indicated toolchain GCCcore/10.2.0 but the content of the file specified foss/2020b, resulting in a module being built with a too specific toolchain and that does not match the filename. I thought the test system would catch something like that, but maybe it falls through the cracks because one is a subchain of the other.

In any case, this PR fixed the toolchain so it is consistent. Sorry about the mess.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Dec 16, 2020

@schiotz I removed the original file for you, using (note the colon before the easyconfig to be removed)

eb --update-pr 11893 --commit-msg msg pytest-xdist-2.1.0-GCCcore-10.2.0.eb :pytest-xdist-2.1.0-foss-2020b.eb

@smoors smoors added the bug fix label Dec 16, 2020
@smoors
Copy link
Copy Markdown
Contributor

smoors commented Dec 16, 2020

Test report by @smoors
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node372.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz (skylake_avx512), Python 2.7.5
See https://gist.github.com/efdd3b142a679d2f299074e5c0152fde for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 16, 2020

@schiotz The file name in the PR itself is actually correct, it matches with the toolchain used in the the file (otherwise the tests would've definitely failed).

Your local file may be named -*GCCcore-10.2.0.eb, but eb --new-pr basically ignores the filename, and derives the correct filename from the contents of the file (which is why it's correct in PR #11883).

Anyway, no big problem, I should have spotted that pytest-xdist doesn't need a full foss toolchain...

Thanks a lot for following up quickly with a fix!

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 16, 2020

@boegelbot please test @ generoso

@boegel boegel added this to the next release (4.3.3?) milestone Dec 16, 2020
@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 16, 2020

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3501.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/cb3fa2a4185c65d0f1a5c258fa089295 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=11893 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_11893 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12309

Test results coming soon (I hope)...

Details

- notification for comment with ID 746889753 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 16, 2020

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3151.skitty.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/7bb1916180e30c08d84a07d3e47d2653 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 16, 2020

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node2676.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/167da806184d85e89056a8ee623bd355 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
generoso-c1-s-2 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/de57a580251a2ecef587a0e5c4428048 for a full test report.

@boegel boegel changed the title BUG FIX: pytest-xdist v2.1.0 w/ Python 3.8.6 fix toolchain for pytest-xdist v2.1.0 w/ Python 3.8.6, should be GCCcore Dec 16, 2020
@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 16, 2020

Going in, thanks @schiotz!

@boegel boegel merged commit f6d5b83 into easybuilders:develop Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants