Skip to content

improve sanity_check_paths for AMD-LibM#11933

Merged
migueldiascosta merged 1 commit intoeasybuilders:developfrom
boegel:20201224100716_new_pr_AMD-LibM322
Dec 25, 2020
Merged

improve sanity_check_paths for AMD-LibM#11933
migueldiascosta merged 1 commit intoeasybuilders:developfrom
boegel:20201224100716_new_pr_AMD-LibM322

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Dec 24, 2020

(created using eb --new-pr)

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Dec 24, 2020

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node3501.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/2be93ae1409956a067cecb0750a0fcf6 for a full test report.

@boegel boegel added this to the next release (4.3.3?) milestone Dec 24, 2020
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Dec 24, 2020

@boegelbot please test @ generoso

@easybuilders easybuilders deleted a comment from boegelbot Dec 24, 2020
@easybuilders easybuilders deleted a comment from boegelbot Dec 24, 2020
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 24, 2020

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=11933 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_11933 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12343

Test results coming soon (I hope)...

Details

- notification for comment with ID 750820210 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 24, 2020

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
generoso-c1-s-2 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/3c6213c005247b13c294160e04deee39 for a full test report.

@migueldiascosta
Copy link
Copy Markdown
Member

migueldiascosta commented Dec 25, 2020

Test report by @migueldiascosta
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
sms - Linux centos linux 7.6.1810, x86_64, AMD EPYC 7601 32-Core Processor (zen), Python 2.7.5
See https://gist.github.com/70c1afb6f72c95b2f4a1eb777e16783f for a full test report.

migueldiascosta
migueldiascosta approved these changes Dec 25, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@migueldiascosta
Copy link
Copy Markdown
Member

migueldiascosta commented Dec 25, 2020

Going in, thanks @boegel!

@migueldiascosta migueldiascosta merged commit 5481d3b into easybuilders:develop Dec 25, 2020
@boegel boegel deleted the 20201224100716_new_pr_AMD-LibM322 branch December 25, 2020 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@migueldiascosta migueldiascosta migueldiascosta approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

4.3.3

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @boegelbot @migueldiascosta