Skip to content

include '-4' in version for AMD-RNG v2.2-4, symlink include/lib subdirs, enhance sanity_check_paths#11934

Merged
migueldiascosta merged 1 commit intoeasybuilders:developfrom
boegel:AMD-RNG
Dec 25, 2020
Merged

include '-4' in version for AMD-RNG v2.2-4, symlink include/lib subdirs, enhance sanity_check_paths#11934
migueldiascosta merged 1 commit intoeasybuilders:developfrom
boegel:AMD-RNG

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Dec 24, 2020

No description provided.

@boegel boegel added this to the next release (4.3.3?) milestone Dec 24, 2020
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Dec 24, 2020

@boegelbot please test @ generoso

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Dec 24, 2020

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3501.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/126af0e0fdaf48c535034f33ba6a5ae5 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 24, 2020

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=11934 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_11934 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12340

Test results coming soon (I hope)...

Details

- notification for comment with ID 750818757 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 24, 2020

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
generoso-c1-s-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/2fb4f35cd6093f3dc6d2280baa6a33b9 for a full test report.

@boegel boegel mentioned this pull request Dec 24, 2020
Merged
@migueldiascosta
Copy link
Copy Markdown
Member

migueldiascosta commented Dec 25, 2020

Test report by @migueldiascosta
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
sms - Linux centos linux 7.6.1810, x86_64, AMD EPYC 7601 32-Core Processor (zen), Python 2.7.5
See https://gist.github.com/4ca1c618562d33ae4d908b8e6bcf581d for a full test report.

migueldiascosta
migueldiascosta approved these changes Dec 25, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@migueldiascosta
Copy link
Copy Markdown
Member

migueldiascosta commented Dec 25, 2020

Going in, thanks @boegel!

@migueldiascosta migueldiascosta merged commit 5d4e031 into easybuilders:develop Dec 25, 2020
@boegel boegel deleted the AMD-RNG branch December 25, 2020 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@migueldiascosta migueldiascosta migueldiascosta approved these changes

Assignees

No one assigned

Labels

change enhancement

Projects

None yet

Milestone

4.3.3

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @boegelbot @migueldiascosta