{tools}[foss/2020a] GetOrganelle v1.7.2 w/ Python 3.8.2#11948
{tools}[foss/2020a] GetOrganelle v1.7.2 w/ Python 3.8.2#11948boegel merged 5 commits intoeasybuilders:developfrom
Conversation
boegel
left a comment
There was a problem hiding this comment.
@deniskristak Please also set use_pip and sanity_pip_check to True
boegel
left a comment
There was a problem hiding this comment.
@deniskristak A couple more things to change:
- add
sanity_pip_check = True(see failing tests); - add
fix_python_shebang_for = ['bin/*.py']to fix the shebang line in the Python script to not hardcode the path to thepythoncommand, but use/usr/bin/env pythoninstead; - add a custom
sanity_check_pathswhich also checks for a couple of the scripts:
sanity_check_paths = {
'files': ['bin/check_annotations.py', 'bin/get_organelle_from_reads.py', 'bin/slim_graph.py'],
'dirs': ['lib/python%(pyshortver)s/site-packages'],
}|
@boegelbot please test @ generoso |
|
Test report by @boegel |
|
@boegel: Request for testing this PR well received on generoso PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 755144959 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegel |
|
Test report by @boegelbot |
|
Test report by @boegel |
|
Going in, thanks @deniskristak! |
(created using
eb --new-pr)