Skip to content

add missing pkg-config build dependency for GObject-Introspection v1.66.1#11949

Merged
verdurin merged 1 commit intoeasybuilders:developfrom
fizwit:20210104152506_new_pr_GObject-Introspection1661
Jan 7, 2021
Merged

add missing pkg-config build dependency for GObject-Introspection v1.66.1#11949
verdurin merged 1 commit intoeasybuilders:developfrom
fizwit:20210104152506_new_pr_GObject-Introspection1661

Conversation

@fizwit
Copy link
Copy Markdown
Contributor

@fizwit fizwit commented Jan 4, 2021

(created using eb --new-pr)

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Jan 7, 2021

@boegelbot please test @ generoso

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Jan 7, 2021

Test report by @verdurin
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
nuc.lan - Linux Fedora 32, x86_64, Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz, Python 3.8.6
See https://gist.github.com/876a89761e47c4ed879cc67d5d64f975 for a full test report.

@verdurin verdurin added this to the next release (4.3.3?) milestone Jan 7, 2021
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 7, 2021

@verdurin: Request for testing this PR well received on generoso

PR test command 'EB_PR=11949 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_11949 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12384

Test results coming soon (I hope)...

Details

- notification for comment with ID 756010993 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 7, 2021

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
generoso-x-2 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/6edf53c0f661548534c9ed04171e62d2 for a full test report.

verdurin
verdurin approved these changes Jan 7, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@verdurin verdurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Jan 7, 2021

Going in, thanks @fizwit!

@verdurin verdurin merged commit a888113 into easybuilders:develop Jan 7, 2021
@boegel boegel changed the title ubuntu requires pkg-config add missing pkg-config build dependency for GObject-Introspection v1.66.1 Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@verdurin verdurin verdurin approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.3.3

Development

Successfully merging this pull request may close these issues.

3 participants

@fizwit @verdurin @boegelbot